Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Heartbeat: implement in both live-reload servers #6927

Merged
merged 1 commit into from
Jul 21, 2023

Conversation

developit
Copy link
Collaborator

@developit developit commented Jul 21, 2023

This updates #6904 to apply the heartbeat to both version of the live-reload server.

  • Docs
  • Tests

Testing Strategy:

Run a remix app in dev mode and load it via a Cloudflare tunnel:

npm run dev & cloudflared tunnel --url http://localhost:57763

Now open the tunnel URL and wait 100 seconds. The socket connection will be closed and the page will reload.

@changeset-bot
Copy link

changeset-bot bot commented Jul 21, 2023

⚠️ No Changeset found

Latest commit: f160ce9

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@brophdawg11 brophdawg11 changed the base branch from main to release-hotfix July 21, 2023 17:36
@brophdawg11 brophdawg11 merged commit 316ef06 into release-hotfix Jul 21, 2023
8 of 9 checks passed
@brophdawg11 brophdawg11 deleted the feat/heartbeat-2 branch July 21, 2023 17:41
@github-actions
Copy link
Contributor

🤖 Hello there,

We just published version 1.19.1-pre.0 which includes this pull request. If you'd like to take it for a test run please try it out and let us know what you think!

Thanks!

@github-actions
Copy link
Contributor

🤖 Hello there,

We just published version 1.19.1 which includes this pull request. If you'd like to take it for a test run please try it out and let us know what you think!

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants