Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: 10-form-vs-fetcher code blocks formatting #7394

Closed
wants to merge 2 commits into from

Conversation

KarelVerschraegen
Copy link
Contributor

@KarelVerschraegen KarelVerschraegen commented Sep 12, 2023

Error was added in the following commit d828b44

Seems like the formatter bot added an extra slash which is also not needed ed12d8d

Before
image

After
image

@changeset-bot
Copy link

changeset-bot bot commented Sep 12, 2023

⚠️ No Changeset found

Latest commit: dcbc397

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@remix-cla-bot
Copy link
Contributor

remix-cla-bot bot commented Sep 12, 2023

Hi @KarelVerschraegen,

Welcome, and thank you for contributing to Remix!

Before we consider your pull request, we ask that you sign our Contributor License Agreement (CLA). We require this only once.

You may review the CLA and sign it by adding your name to contributors.yml.

Once the CLA is signed, the CLA Signed label will be added to the pull request.

If you have already signed the CLA and received this response in error, or if you have any questions, please contact us at hello@remix.run.

Thanks!

- The Remix team

@KarelVerschraegen KarelVerschraegen changed the base branch from main to dev September 12, 2023 08:17
@KarelVerschraegen KarelVerschraegen changed the title docs code 10-form-vs-fetcher code blocks formatting Sep 12, 2023
@remix-cla-bot
Copy link
Contributor

remix-cla-bot bot commented Sep 12, 2023

Thank you for signing the Contributor License Agreement. Let's get this merged! 🥳

@KarelVerschraegen KarelVerschraegen changed the title 10-form-vs-fetcher code blocks formatting docs: 10-form-vs-fetcher code blocks formatting Sep 12, 2023
@MichaelDeBoey
Copy link
Member

Thanks for opening this PR! 🙏

However, I'm going to close this as this is already fixed by #7191

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants