Minor client data edge case fixes #8253
Conversation
🦋 Changeset detectedLatest commit: 9d449b5 The changes in this PR will be included in the next version bump. This PR includes changesets to release 16 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
| params, | ||
| async serverLoader() { | ||
| if (isHydrationRequest) { | ||
| isHydrationRequest = false; |
There was a problem hiding this comment.
This was incorrect and only worked if they call serverLoader. Instead we need to toggle this back off in the first loader execution
There was a problem hiding this comment.
Hiding whitespace makes this a bit easier to view - but now we turn it off in a finally in the loader
| if (!route.hasAction) { | ||
| throw getNoServerHandlerError("action", route.id); | ||
| } |
There was a problem hiding this comment.
Ensure'd we have these in every flow
| isHydrationRequest = false; | ||
|
|
||
| // Throw an error if a clientLoader tries to call a serverLoader that doesn't exist | ||
| if (initialData === undefined) { |
There was a problem hiding this comment.
Don't do this from a data check - do it from a manifest hasLoader check
|
🤖 Hello there, We just published version Thanks! |
|
🤖 Hello there, We just published version Thanks! |
|
🤖 Hello there, We just published version Thanks! |
No description provided.