opt-in type inference for single-fetch #9272
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🦋 Changeset detectedLatest commit: f66de1a The changes in this PR will be included in the next version bump. This PR includes changesets to release 16 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
pcattori
force-pushed
the
pedro/release-single-fetch-types
branch
from
57f8f07
to
7ad6d97
Compare
pcattori
force-pushed
the
pedro/release-single-fetch-types
branch
from
7ad6d97
to
5222956
Compare
|
Awesome! |
.changeset/young-eagles-grab.md
Outdated
|
|
||
| Opt-in types for single-fetch | ||
|
|
||
| To opt-in to type inference for single-fetch, add `future/single-fetch.d.ts` to `include` in your `tsconfig.json`: |
brophdawg11
reviewed
Apr 22, 2024
Comment on lines
44
to
47
| export function useLoaderData<T>(): T extends Loader | ||
| ? Awaited<ReturnType<T>> | ||
| : never; | ||
|
|
There was a problem hiding this comment.
We will need to fork in here and use the old SerializeFrom types if a user returns a Response from the loader/actionsince that will still go through res.json()
This was referenced Apr 22, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Note: using
includerather thantypeRoots/typessince those are designed for@typespackages andincludeis lighter weight