Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix single-fetch types for functions that return unions #9999

Merged
merged 1 commit into from
Sep 18, 2024

Conversation

pcattori
Copy link
Contributor

@pcattori pcattori commented Sep 18, 2024

Supercedes #9834
Fixes #9826 , #9998

Co-authored-by: Michael McDermott <michael.g.mcdermott@gmail.com>
Copy link

changeset-bot bot commented Sep 18, 2024

🦋 Changeset detected

Latest commit: 6edf036

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 16 packages
Name Type
@remix-run/server-runtime Patch
@remix-run/cloudflare Patch
@remix-run/deno Patch
@remix-run/dev Patch
@remix-run/node Patch
@remix-run/react Patch
@remix-run/testing Patch
@remix-run/cloudflare-pages Patch
@remix-run/cloudflare-workers Patch
@remix-run/architect Patch
@remix-run/express Patch
@remix-run/serve Patch
create-remix Patch
remix Patch
@remix-run/css-bundle Patch
@remix-run/eslint-config Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@pcattori
Copy link
Contributor Author

pcattori commented Sep 18, 2024

@michaelgmcd I tried to checkout your #9834 PR, but gh repo checkout was struggling with it (probably due to merge conflicts? 🤷‍♂️) so I adapted your work in this PR and added you as a co-author of the commit so you get credit. Thanks for your work on this!

@pcattori pcattori linked an issue Sep 18, 2024 that may be closed by this pull request
@pcattori pcattori merged commit 4a95727 into dev Sep 18, 2024
5 checks passed
@pcattori pcattori deleted the pedro/distribute-single-fetch-types branch September 18, 2024 02:17
@github-actions github-actions bot added the awaiting release This issue has been fixed and will be released soon label Sep 18, 2024
@brophdawg11 brophdawg11 linked an issue Sep 18, 2024 that may be closed by this pull request
Copy link
Contributor

🤖 Hello there,

We just published version 2.12.1-pre.0 which includes this pull request. If you'd like to take it for a test run please try it out and let us know what you think!

Thanks!

Copy link
Contributor

🤖 Hello there,

We just published version 2.12.1 which includes this pull request. If you'd like to take it for a test run please try it out and let us know what you think!

Thanks!

@github-actions github-actions bot removed the awaiting release This issue has been fixed and will be released soon label Sep 19, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
1 participant