feat(nuget): allow detecting source URLs via package contents #28071
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fgreinacher
force-pushed
the
feat/nuget-source-urls
branch
2 times, most recently
from
1bb8271
to
cda4fb5
Compare
fgreinacher
commented
Mar 21, 2024
fgreinacher
force-pushed
the
feat/nuget-source-urls
branch
from
cda4fb5
to
d5afd4e
Compare
fgreinacher
force-pushed
the
feat/nuget-source-urls
branch
from
d5afd4e
to
df50bbc
Compare
|
Do you have a preference whether this should be controlled via a proper configuration option or an experimental env var? |
viceice
reviewed
Mar 21, 2024
lib/modules/datasource/nuget/__fixtures__/nlog/NLog.4.7.3.nupkg
Outdated
Show resolved
Hide resolved
fgreinacher
force-pushed
the
feat/nuget-source-urls
branch
2 times, most recently
from
4b0a1c8
to
95d6c25
Compare
|
OK, this is now ready for review. I have verified it with our internal Artifactory and also also using my public test Artifactory: https://github.com/fgreinacher/renovate-artifactory-source-url-fixed/pulls |
fgreinacher
force-pushed
the
feat/nuget-source-urls
branch
from
95d6c25
to
738418d
Compare
rarkins
requested changes
Mar 23, 2024
6 tasks
Also use cache decorator instead of manual logic
fgreinacher
force-pushed
the
feat/nuget-source-urls
branch
from
36bcb74
to
565e867
Compare
6 tasks
Co-authored-by: Michael Kriese <michael.kriese@visualon.de>
viceice
previously approved these changes
Apr 2, 2024
rarkins
reviewed
Apr 11, 2024
This comment was marked as off-topic.
This comment was marked as off-topic.
Sorry, something went wrong.
viceice
approved these changes
Apr 15, 2024
rarkins
reviewed
Apr 20, 2024
rarkins
approved these changes
Apr 20, 2024
|
🎉 This PR is included in version 37.311.0 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
Adapts the NuGet datasource to determine package source URLs from the
nupkgfile in cases where the API does not provide the PackageBaseAddress resourceContext
#28041
Documentation (please check one with an [x])
How I've tested my work (please select one)
I have verified these changes via:
⚒️ with ❤️ by Siemens