fix(go): missing Go module v2+ major upgrades #8945
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Go dependencies may (if v2 or above) contain the version in the dependency URL. When checking for submodules the version should be stripped to ensure that the available versions is correctly filtered based on the submodule name. e.g * github.com/org/mod/v5 should look for all releases named vx.y.z * github.com/org/mod/submodule should look for all releases named submodule/vx.y.z * github.com/org/mod/submodule/v2 should look for all released name submodule/vx.y.z
56KBs
changed the title
rarkins
approved these changes
Mar 7, 2021
|
🎉 This PR is included in version 24.75.1 🎉 The release is available on:
Your semantic-release bot 📦🚀 |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes:
Go dependencies may (if v2 or above) contain the version in the dependency URL. When checking for submodules the version should be stripped to ensure that the available versions is correctly filtered based on the submodule name.
e.g
Issues #8562 & #8525 are still present following these changes meaning PR/MRs raised won't actually function correctly, but at least alerts will be generated again
Context:
Closes #8937
Documentation (please check one with an [x])
How I've tested my work (please tick one)
I have verified these changes via: