fix(go): fix go module double suffix on major upgrade #8946
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 3 commits
March 2, 2021 17:53
when upgrading a major version in which the module contains the version, the new major version would be appended to the current module, resulting in a module URL which was incorrect. this fixes the logic to ensure that we only pin the latest version if we don't currently have a version, otherwise we will add/replace the version where applicable
depName should include the full version, this change managed to escape the previous commit
checking the current value is v0/v1 is not necessary as adding the version for the dependency name is always required if it does not exist, regardless of current versions if the dependency already had a version within the dependency name, it will be replaced with the new major version
rarkins
approved these changes
Mar 5, 2021
|
🎉 This PR is included in version 24.73.1 🎉 The release is available on:
Your semantic-release bot 📦🚀 |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes:
when upgrading a major version in which the module contains the version, the new major version would be appended to the current module, resulting in a module URL which was incorrect.
this fixes the logic to ensure that we only pin the latest version if we don't currently have a version, otherwise we will add/replace the version where applicable
Context:
Closes #8525 & Closes #8562
Documentation (please check one with an [x])
How I've tested my work (please tick one)
I have verified these changes via: