EPMRPP-87023 || No UI validation on Create/Edit Gitlab integration modals when user enters non-digits in project ID field #3
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…dals when user enters non-digits in project ID field
Vadim73i
requested review from
AmsterGet and
Bam6ycha
and removed request for
AmsterGet
Bam6ycha
requested changes
Oct 24, 2023
ui/src/components/integrationFormFields/integrationFormFields.tsx
Outdated
Show resolved
Hide resolved
ui/src/components/integrationFormFields/integrationFormFields.tsx
Outdated
Show resolved
Hide resolved
ui/src/components/integrationFormFields/integrationFormFields.tsx
Outdated
Show resolved
Hide resolved
Bam6ycha
approved these changes
Oct 25, 2023
AmsterGet
reviewed
Oct 25, 2023
| @@ -33,7 +45,7 @@ export const IntegrationFormFields: FC<IntegrationFormFieldsInterface> = (props) | |||
| isRequired | |||
| > | |||
| <FieldErrorHint provideHint={false}> | |||
| <FieldText maxLength={55} defaultWidth={false} /> | |||
| <FieldText maxLength={MAX_LENGTH} defaultWidth={false} /> | |||
There was a problem hiding this comment.
Do we need to remove maxLength property for the fields as discussed previously?
In case it is set, user input will be cut while doing copy-paste.
Discuss with BA.
AmsterGet
approved these changes
Oct 27, 2023
AmsterGet
deleted the
feature/EPMRPP-87023-No-UI-validation-on-Create/Edit-Gitlab-integration-modals-when-user-enters-non-digits-in-project-ID-field
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.