Mega evolution animation is a little smoother #4816
Conversation
kleenxfeu
force-pushed
the
master
branch
3 times, most recently
from
8755657
to
b2bf85e
Compare
src/battle_anim_effects_3.c
Outdated
| @@ -2325,6 +2325,88 @@ void AnimTask_SwallowDeformMon(u8 taskId) | |||
| } | |||
| } | |||
|
|
|||
| void AnimTask_MegaSwapSprite(u8 taskId) | |||
There was a problem hiding this comment.
Since it's used for Mega/Ultra/Primal, maybe change the name to sth like AnimTask_SmoothSpriteSwap
src/battle_anim_effects_3.c
Outdated
| { | ||
| case 0: | ||
| gTasks[taskId].data[11] = gSprites[spriteId].x; // Save battler position | ||
| gSprites[spriteId].x = -64; // hide it from screen to avoid the blip/glitch effect when swapping the sprite |
| break; | ||
| } | ||
| } | ||
|
|
||
| void AnimTask_TransformMon(u8 taskId) |
There was a problem hiding this comment.
Since it's similar to AnimTask_TransformMon I would create a helper function such as AnimSpriteChange (or a different name) which would be used for both of these with an argument such as bool32 isTransform to differentiate between the two
There was a problem hiding this comment.
@DizzyEggg, do you mean to combine AnimTask_TransformMon +AnimTask_HideSwapSprite' and isTransform will control if it should skip the steps that are not needed?
Should be good now |
|
@kleenxfeu can you make a commit (either change something or just commit and revert some nonsense) just so that CI runs again? |
|
@kleeenexfeu Why did you ignore my |
Get rid of the transform/mozaic animation that serves no purpose
Applied it for primal reversions and ultra burst as well.
The function can be partly imitated to hide the sprite during the animation of other gimmicks so that it doesn't flicker/appear too early
See the difference here : https://discord.com/channels/419213663107416084/774393519569502268/1251840634264748074EDIT by AsparagusEduardo:
For the sake of self-contained PR documentation, I'm posting the GIFs here (before and after):