Adds some Snatch interactions, fixes for Dragon Darts, Trace, Primal Reversion, Protosynthesis/Quark Drive #5430
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…rbing abilities (Volt Absorb, Motor Drive)
…ersion, add tests
|
I think there is some Trace script that could also be cleaned up. |
AlexOn1ine
approved these changes
Sep 24, 2024
AlexOn1ine
reviewed
Sep 26, 2024
Comment on lines
-10014
to
+10010
| call BattleScript_AbilityPopUpTarget | ||
| call BattleScript_AbilityPopUpScripting |
There was a problem hiding this comment.
I just realized that I wrote this. I deserve to be banished to the shadow realm for this.
Very smart.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes Electrified Dragon Darts sometimes not correctly avoiding targets with ability immunity (Volt Absorb, Motor Drive)
Fixes Trace not activating a switch-in ability it traces, removes unused
RESOURCE_FLAG_TRACED.Fixes multiple Primal Reversions not occurring after multiple battlers fainted.
Fixes the wrong battler's ability pop up occuring from Switch in ability bug when mulitply mons faint at the same time #5427 (doesn't fix other battlers' Booster Energy not activating)
Simplified Quash code (assumes the turn order is correct when using the move)
Added tests for Dancer; also for the Dragon Darts, Trace, Primal Reversion fixes
Issue(s) that this PR fixes
Fixes #5425, fixes #5426
Discord contact info
PhallenTree