Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

BitException::getErrorCode() marked as 'const' #64

Merged
merged 1 commit into from
Jan 2, 2022

Conversation

DymOK93
Copy link
Contributor

@DymOK93 DymOK93 commented Jan 1, 2022

Description

BitException::getErrorCode() marked as const

Motivation and Context

Closes #63

How Has This Been Tested?

Build the following code:

// main.cpp
#include <bit7zlibrary.hpp>
#include <iostream>
#include <iomanip>

int main {
  try {
    bit7z::Bit7zLibrary lib;
  } catch (const BitException& exc) {
    std::cerr << "Unable to unpack an archive: error " << std::hex << exc.getErrorCode() << std::endl;
  }
  return 0;
}

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.

@DymOK93 DymOK93 force-pushed the hotfix_bitexception_geterrorcode branch from 444b5a9 to 28f33e3 Compare January 1, 2022 14:12
@DymOK93 DymOK93 changed the title BitException::getErrorCode() marked as 'const noexcept' BitException::getErrorCode() marked as 'const' Jan 1, 2022
@DymOK93
Copy link
Contributor Author

DymOK93 commented Jan 1, 2022

Sorry, I forgot that MSVC2012 doesn't support the noexcept specifier. Fixed with forced push.

@rikyoz rikyoz self-assigned this Jan 2, 2022
@rikyoz rikyoz merged commit 1165de8 into rikyoz:master Jan 2, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Feature Request]: mark BitException::getErrorCode() as const
2 participants