refactor: make mypy happy about Torrent.is_paused
#457
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
trim21
changed the title
Torrent.is_pausedTorrent.is_paused
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #457 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 15 15
Lines 1929 1935 +6
Branches 373 376 +3
=========================================
+ Hits 1929 1935 +6 ☔ View full report in Codecov by Sentry. |
|
That's unfortunate; this seems to be the upstream issue documenting this behavior in mypy. Given how often this library is aliasing things, I'd be surprised if this is the only case. I'll see if I can proactively find others. |
- When a property method is aliased to another label, mypy considers the type of the alias to be a callable instead of the return type of the method; therefore, mypy is likely to error when using them - This resolves the issue for client.application, client.authorization, and TorrentState.is_paused - Instances of the issue (mostly in client.app) arising from camelCase aliases will not be resolved; use the snake case names as a workaround
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
mypy doesn't think
is_pausedis a property so it raise a warningerror: Function "is_paused" could always be true in boolean context [truthy-function]