Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix missing identityref namespace #322

Merged

Conversation

fperrin
Copy link
Contributor

@fperrin fperrin commented Oct 15, 2023

Rebase of #220 over latest master, plus UT for the issue fixed here.

fperrin and others added 2 commits October 15, 2023 19:51
When we generate python code from Yang module, the restriction_arg for
the field doesn't include module name as the prefix.
Copy link
Collaborator

@JoseIgnacioTamayo JoseIgnacioTamayo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@JoseIgnacioTamayo JoseIgnacioTamayo merged commit 835f1df into robshakir:master Nov 30, 2023
6 checks passed
JoseIgnacioTamayo pushed a commit that referenced this pull request Dec 11, 2023
* Add test coverage for identityref namespace fix

* Fix missing namespace in identityref field

When we generate python code from Yang module, the restriction_arg for
the field doesn't include module name as the prefix.

---------

Co-authored-by: guojunzhang <guojunzhang1981@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants