BUG: Inaccurate means for float16 TIFFs #176
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When taking the mean of an array of ints, numpy uses float64 for the output.
But when taking the mean of an array of floats, numpy uses the same float precision as the original array.
That leads to the mean being noticably less accurate when taking the mean of TIFFs that are float16 (single precision). We fix this by using float64 for all the means.
This issue wasn't caught by the unit tests before because they were also doing the less accurate rounding to determine the target values.