Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DEV: Update pre-commit stack and fix executable files #234

Merged
merged 6 commits into from
Jul 10, 2021

Conversation

scottclowe
Copy link
Member

  • Remove executable flag from unexecutable files. I think the flag was wrong because the files were originally committed on Windows?
  • Add executable flag to setup.py
  • Migrate from black_nbconvert to nbqa-black, which is actively maintained and has a release that supports cell magic
  • Add new hooks from pre-commit/pygrep-hooks
  • Add new hooks from pre-commit/pre-commit-hooks

@codecov
Copy link

codecov bot commented Jul 10, 2021

Codecov Report

Merging #234 (bf88326) into master (91b9c91) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #234   +/-   ##
=======================================
  Coverage   92.75%   92.75%           
=======================================
  Files           8        8           
  Lines         939      939           
  Branches      197      197           
=======================================
  Hits          871      871           
  Misses         33       33           
  Partials       35       35           
Flag Coverage Δ
nbsmoke 66.02% <ø> (ø)
unittests 92.33% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
fissa/extraction.py 95.04% <ø> (ø)
fissa/neuropil.py 91.66% <ø> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 91b9c91...bf88326. Read the comment docs.

@scottclowe scottclowe merged commit 17f1cd3 into rochefort-lab:master Jul 10, 2021
@scottclowe scottclowe deleted the dev_pre-commit-update branch July 10, 2021 11:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant