Fix warnings caused by Ruby 2.7 update #530
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Cam anyone review my PR? |
|
Hi @chopraanmol1 , @simonoff , |
|
Adding my 👍 to get this reviewed and release. It a blocker for folks trying to upgrade to Ruby 2.7.x |
|
Maybe we should just drop Ruby 2.3 and 2.4 given they're both end of support. |
|
@jonspalmer would be great! |
simonoff
reviewed
Jul 28, 2020
lib/roo/csv.rb
Outdated
|
|
||
| # From Ruby 2.5, options argument of CSV.new/CSV.foreach is a keyword argument. | ||
| # Before Ruby 2.5, that argument is a Hash. | ||
| # Therefore, this workaround can be removed if Ruby 2.3 and 2.4 are dropped. |
There was a problem hiding this comment.
Yes, please remove such workaround.
There was a problem hiding this comment.
Can I edit gemspec and .travis.yml to drop ruby 2.3 & 2.4 in this branch: ruby_27_support?
There was a problem hiding this comment.
I removed WA for Ruby 2.3 & 2.4 and also edited gemspec and .travis.yml too.
|
Can we get this published?? 🙏 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Fixed following warnings caused by Ruby 2.7 update.