Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[rclcpp] Type Adaptation feature #1557

Merged
merged 38 commits into from
May 7, 2021
Merged

[rclcpp] Type Adaptation feature #1557

merged 38 commits into from
May 7, 2021

Commits on May 4, 2021

  1. initial version of type_adaptor.hpp 

    Signed-off-by: William Woodall <william@osrfoundation.org>
    @wjwwood
    wjwwood committed May 4, 2021
    Configuration menu
    Copy the full SHA
    07c3d54 View commit details
    Browse the repository at this point in the history

  2. initial version of rclcpp::get_message_type_support_handle() 

    Signed-off-by: William Woodall <william@osrfoundation.org>
    @wjwwood
    wjwwood committed May 4, 2021
    Configuration menu
    Copy the full SHA
    86713bd View commit details
    Browse the repository at this point in the history

  3. initial version of rclcpp::is_ros_compatible_type check 

    Signed-off-by: William Woodall <william@osrfoundation.org>
    @wjwwood
    wjwwood committed May 4, 2021
    Configuration menu
    Copy the full SHA
    f3c79d4 View commit details
    Browse the repository at this point in the history

  4. fixup include statement order in publisher.hpp 

    Signed-off-by: William Woodall <william@osrfoundation.org>
    @wjwwood
    wjwwood committed May 4, 2021
    Configuration menu
    Copy the full SHA
    e7ec97c View commit details
    Browse the repository at this point in the history

  5. use new rclcpp::get_message_type_support_handle() and check in Publisher 

    Signed-off-by: William Woodall <william@osrfoundation.org>
    @wjwwood
    wjwwood committed May 4, 2021
    Configuration menu
    Copy the full SHA
    47dd8cd View commit details
    Browse the repository at this point in the history

  6. update adaptor->adapter, update TypeAdapter to use two arguments, add… 

    … implicit default

Signed-off-by: William Woodall <william@osrfoundation.org>
    @wjwwood
    wjwwood committed May 4, 2021
    Configuration menu
    Copy the full SHA
    1972512 View commit details
    Browse the repository at this point in the history

  7. move away from shared_ptr<allocator> to just allocator, like the STL 

    Signed-off-by: William Woodall <william@osrfoundation.org>
    @wjwwood
    wjwwood committed May 4, 2021
    Configuration menu
    Copy the full SHA
    929eb78 View commit details
    Browse the repository at this point in the history

  8. fixes to TypeAdapter and adding new publish function signatures 

    Signed-off-by: William Woodall <william@osrfoundation.org>
    @wjwwood
    wjwwood committed May 4, 2021
    Configuration menu
    Copy the full SHA
    283b44d View commit details
    Browse the repository at this point in the history

  9. bugfixes 

    Signed-off-by: William Woodall <william@osrfoundation.org>
    @wjwwood
    wjwwood committed May 4, 2021
    Configuration menu
    Copy the full SHA
    86ebb4a View commit details
    Browse the repository at this point in the history

  10. more bugfixes 

    Signed-off-by: William Woodall <william@osrfoundation.org>
    @wjwwood
    wjwwood committed May 4, 2021
    Configuration menu
    Copy the full SHA
    9b57a0c View commit details
    Browse the repository at this point in the history

  11. Add nullptr check 

    Signed-off-by: Audrow Nash <audrow@hey.com>
    @paudrow @wjwwood
    paudrow authored and wjwwood committed May 4, 2021
    Configuration menu
    Copy the full SHA
    2330ce1 View commit details
    Browse the repository at this point in the history

  12. Remove public from struct inheritance 

    Signed-off-by: Audrow Nash <audrow@hey.com>
    @paudrow @wjwwood
    paudrow authored and wjwwood committed May 4, 2021
    Configuration menu
    Copy the full SHA
    af222fb View commit details
    Browse the repository at this point in the history

  13. Add tests for publisher with type adapter 

    Signed-off-by: Audrow Nash <audrow@hey.com>
    @paudrow @wjwwood
    paudrow authored and wjwwood committed May 4, 2021
    Configuration menu
    Copy the full SHA
    fa93fa6 View commit details
    Browse the repository at this point in the history

  14. Update packages to C++17 

    Signed-off-by: Audrow Nash <audrow@hey.com>
    @paudrow @wjwwood
    paudrow authored and wjwwood committed May 4, 2021
    Configuration menu
    Copy the full SHA
    8f5c70a View commit details
    Browse the repository at this point in the history

  15. Revert "Update packages to C++17" 

    This reverts commit 4585605.

Signed-off-by: William Woodall <william@osrfoundation.org>
    @wjwwood
    wjwwood committed May 4, 2021
    Configuration menu
    Copy the full SHA
    65d731f View commit details
    Browse the repository at this point in the history

  16. Begin updating AnySubscriptionCallback to use the TypeAdapter 

    Signed-off-by: Audrow Nash <audrow@hey.com>
    @paudrow @wjwwood
    paudrow authored and wjwwood committed May 4, 2021
    Configuration menu
    Copy the full SHA
    9533f94 View commit details
    Browse the repository at this point in the history

  17. Use type adapter's custom type 

    Signed-off-by: Audrow Nash <audrow@hey.com>
    @paudrow @wjwwood
    paudrow authored and wjwwood committed May 4, 2021
    Configuration menu
    Copy the full SHA
    92d3327 View commit details
    Browse the repository at this point in the history

  18. Correct which AnySubscriptionCallbackHelper is selected 

    Signed-off-by: Audrow Nash <audrow@hey.com>
    @paudrow @wjwwood
    paudrow authored and wjwwood committed May 4, 2021
    Configuration menu
    Copy the full SHA
    239be27 View commit details
    Browse the repository at this point in the history

  19. Setup dispatch function to work with adapted types 

    Signed-off-by: Audrow Nash <audrow@hey.com>
    @paudrow @wjwwood
    paudrow authored and wjwwood committed May 4, 2021
    Configuration menu
    Copy the full SHA
    e37a5f6 View commit details
    Browse the repository at this point in the history

  20. Improve template logic on dispatch methods 

    Signed-off-by: Audrow Nash <audrow@hey.com>
    @paudrow @wjwwood
    paudrow authored and wjwwood committed May 4, 2021
    Configuration menu
    Copy the full SHA
    3cfc1e6 View commit details
    Browse the repository at this point in the history

  21. implement TypeAdapter for Subscription 

    Signed-off-by: William Woodall <william@osrfoundation.org>
    @wjwwood
    wjwwood committed May 4, 2021
    Configuration menu
    Copy the full SHA
    14d2a87 View commit details
    Browse the repository at this point in the history

  22. Add intraprocess tests with all supported message types 

    Signed-off-by: Audrow Nash <audrow@hey.com>
    @paudrow @wjwwood
    paudrow authored and wjwwood committed May 4, 2021
    Configuration menu
    Copy the full SHA
    b80bc07 View commit details
    Browse the repository at this point in the history

  23. Add intra process tests 

    Signed-off-by: Audrow Nash <audrow@hey.com>
    @paudrow @wjwwood
    paudrow authored and wjwwood committed May 4, 2021
    Configuration menu
    Copy the full SHA
    5352a9b View commit details
    Browse the repository at this point in the history

  24. Add tests for subscription with type adapter 

    Signed-off-by: Audrow Nash <audrow@hey.com>
    @paudrow @wjwwood
    paudrow authored and wjwwood committed May 4, 2021
    Configuration menu
    Copy the full SHA
    de9fb15 View commit details
    Browse the repository at this point in the history

  25. Fix null allocator test 

    Signed-off-by: Audrow Nash <audrow@hey.com>
    @paudrow @wjwwood
    paudrow authored and wjwwood committed May 4, 2021
    Configuration menu
    Copy the full SHA
    95d020e View commit details
    Browse the repository at this point in the history

  26. Handle serialized message correctly 

    Signed-off-by: Audrow Nash <audrow@hey.com>
    @paudrow @wjwwood
    paudrow authored and wjwwood committed May 4, 2021
    Configuration menu
    Copy the full SHA
    9a234f1 View commit details
    Browse the repository at this point in the history

  27. Fix generic subscription 

    Signed-off-by: Audrow Nash <audrow@hey.com>
    @paudrow @wjwwood
    paudrow authored and wjwwood committed May 4, 2021
    Configuration menu
    Copy the full SHA
    8b174dd View commit details
    Browse the repository at this point in the history

  28. Fix trailing space 

    Signed-off-by: Audrow Nash <audrow@hey.com>
    @paudrow @wjwwood
    paudrow authored and wjwwood committed May 4, 2021
    Configuration menu
    Copy the full SHA
    493119f View commit details
    Browse the repository at this point in the history

  29. fix some issues found while testing type_adapter in demos 

    Signed-off-by: William Woodall <william@osrfoundation.org>
    @wjwwood
    wjwwood committed May 4, 2021
    Configuration menu
    Copy the full SHA
    206f296 View commit details
    Browse the repository at this point in the history

  30. add more tests, WIP 

    Signed-off-by: William Woodall <william@osrfoundation.org>
    @wjwwood
    wjwwood committed May 4, 2021
    Configuration menu
    Copy the full SHA
    1b9fbd5 View commit details
    Browse the repository at this point in the history

  31. Improve pub/sub tests 

    Signed-off-by: Audrow Nash <audrow@hey.com>
    @paudrow @wjwwood
    paudrow authored and wjwwood committed May 4, 2021
    Configuration menu
    Copy the full SHA
    d2122df View commit details
    Browse the repository at this point in the history

  32. Apply uncrustify formatting 

    Signed-off-by: Audrow Nash <audrow@hey.com>
    @paudrow @wjwwood
    paudrow authored and wjwwood committed May 4, 2021
    Configuration menu
    Copy the full SHA
    aa236af View commit details
    Browse the repository at this point in the history

  33. finish new tests for any subscription callback with type adapter 

    Signed-off-by: William Woodall <william@osrfoundation.org>
    @wjwwood
    wjwwood committed May 4, 2021
    Configuration menu
    Copy the full SHA
    d12b887 View commit details
    Browse the repository at this point in the history

  34. fix adapt_type<...>::as<...> syntax 

    Signed-off-by: William Woodall <william@osrfoundation.org>
    @wjwwood
    wjwwood committed May 4, 2021
    Configuration menu
    Copy the full SHA
    e77bac0 View commit details
    Browse the repository at this point in the history

  35. fix explicit template instantiation of create_subscription() in new test 

    Signed-off-by: William Woodall <william@osrfoundation.org>
    @wjwwood
    wjwwood committed May 4, 2021
    Configuration menu
    Copy the full SHA
    4ac3b40 View commit details
    Browse the repository at this point in the history

  36. cpplint fix 

    Signed-off-by: William Woodall <william@osrfoundation.org>
    @wjwwood
    wjwwood committed May 4, 2021
    Configuration menu
    Copy the full SHA
    35adfa7 View commit details
    Browse the repository at this point in the history

Commits on May 6, 2021

  1. Fix bug by aligning allocator types on both sides of ipm 

    Signed-off-by: Audrow Nash <audrow@hey.com>
    @paudrow
    paudrow committed May 6, 2021
    Configuration menu
    Copy the full SHA
    a7887d3 View commit details
    Browse the repository at this point in the history

Commits on May 7, 2021

  1. Fix intra process manager tests 

    Signed-off-by: Audrow Nash <audrow@hey.com>
    @paudrow
    paudrow committed May 7, 2021
    Configuration menu
    Copy the full SHA
    d155471 View commit details
    Browse the repository at this point in the history