Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Foxy is now EOL #3700

Merged
merged 4 commits into from
Jun 21, 2023
Merged

Foxy is now EOL #3700

merged 4 commits into from
Jun 21, 2023

Conversation

moriarty
Copy link
Contributor

@moriarty moriarty commented Jun 1, 2023

It is June 1 2023 and Foxy has reached EOL

Copy link
Collaborator

@fujitatomoya fujitatomoya left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@moriarty thanks for the contribution.

can you add the following changes?

@fujitatomoya
Copy link
Collaborator

@cottsay @audrow @Yadunund can you have another review?
CC: @clalancette

@clalancette
Copy link
Contributor

We have not officially EOLed Foxy yet, so we should hold off on this. It is coming soon.

@moriarty
Copy link
Contributor Author

moriarty commented Jun 1, 2023

We have not officially EOLed Foxy yet, so we should hold off on this. It is coming soon.

Why is it not official yet?

The original EOL date has passed.

@clalancette
Copy link
Contributor

Why is it not official yet?

We haven't done the final sync. The work is in progress. In general, we don't guarantee an EOL date, just have an approximate end.

@moriarty
Copy link
Contributor Author

moriarty commented Jun 1, 2023

Why is it not official yet?

We haven't done the final sync. The work is in progress. In general, we don't guarantee an EOL date, just have an approximate end.

I've set the date in that line to the last day of May 2023.
It seems odd to extend the EOL into June after it's been documented for a long time as May 2023.

https://www.ros.org/reps/rep-2000.html#foxy-fitzroy-may-2020-may-2023

For any projects which want to support current EOL versions this is effects things like resource planning and scheduling, and continuous integration budgets. I understand that the sync sometimes happens when the sync happens and that the last sync can easily get delayed due to Iron, but other non-core ROS 2 projects have already started assuming Foxy is EOL and dropping CI etc

@clalancette
Copy link
Contributor

I understand that the sync sometimes happens when the sync happens and that the last sync can easily get delayed due to Iron

Yes, that's generally the reason. It's not impossible to do it at the same time as releasing a new release, but it can be hard at times. That was the case this year.

@clalancette clalancette self-assigned this Jun 8, 2023
@moriarty
Copy link
Contributor Author

moriarty commented Jun 9, 2023

used GitHub UI to fixup conflicts and remove .rst extension from #3723

source/Releases.rst Outdated Show resolved Hide resolved
@moriarty
Copy link
Contributor Author

@moriarty
Copy link
Contributor Author

@moriarty thanks for the contribution.

can you add the following changes?

I Applied your feedback, could you re-review?

moriarty and others added 4 commits June 21, 2023 08:57
It is June 1 2023 and Foxy has reached EOL

Signed-off-by: Alex Moriarty <alex.moriarty@picknik.ai>
- review feedback:
  - mergify config
  - background color
  - add date to date

Signed-off-by: Alex Moriarty <alex.moriarty@picknik.ai>
Signed-off-by: Chris Lalancette <clalancette@gmail.com>
@clalancette clalancette added the backport-all backport at reviewers discretion; from rolling to all versions label Jun 21, 2023
@clalancette clalancette merged commit 5248891 into ros2:rolling Jun 21, 2023
4 checks passed
mergify bot pushed a commit that referenced this pull request Jun 21, 2023
* Foxy is now EOL

* [EOL] Foxy

- review feedback:
  - mergify config
  - background color
  - add date to date

Official ROS 2 Foxy EOL Date June 20th, 2023

https://twitter.com/OpenRoboticsOrg/status/1666484720585277443

* Remove Foxy from the top-level Releases page.

Signed-off-by: Alex Moriarty <alex.moriarty@picknik.ai>
Signed-off-by: Chris Lalancette <clalancette@gmail.com>
(cherry picked from commit 5248891)
mergify bot pushed a commit that referenced this pull request Jun 21, 2023
* Foxy is now EOL

* [EOL] Foxy

- review feedback:
  - mergify config
  - background color
  - add date to date

Official ROS 2 Foxy EOL Date June 20th, 2023

https://twitter.com/OpenRoboticsOrg/status/1666484720585277443

* Remove Foxy from the top-level Releases page.

Signed-off-by: Alex Moriarty <alex.moriarty@picknik.ai>
Signed-off-by: Chris Lalancette <clalancette@gmail.com>
(cherry picked from commit 5248891)
@clalancette
Copy link
Contributor

@Mergifyio backport foxy

@mergify
Copy link
Contributor

mergify bot commented Jun 21, 2023

backport foxy

✅ Backports have been created

mergify bot pushed a commit that referenced this pull request Jun 21, 2023
* Foxy is now EOL

* [EOL] Foxy

- review feedback:
  - mergify config
  - background color
  - add date to date

Official ROS 2 Foxy EOL Date June 20th, 2023

https://twitter.com/OpenRoboticsOrg/status/1666484720585277443

* Remove Foxy from the top-level Releases page.

Signed-off-by: Alex Moriarty <alex.moriarty@picknik.ai>
Signed-off-by: Chris Lalancette <clalancette@gmail.com>
(cherry picked from commit 5248891)
clalancette pushed a commit that referenced this pull request Jun 21, 2023
* Foxy is now EOL

* [EOL] Foxy

- review feedback:
  - mergify config
  - background color
  - add date to date

Official ROS 2 Foxy EOL Date June 20th, 2023

https://twitter.com/OpenRoboticsOrg/status/1666484720585277443

* Remove Foxy from the top-level Releases page.

Signed-off-by: Alex Moriarty <alex.moriarty@picknik.ai>
Signed-off-by: Chris Lalancette <clalancette@gmail.com>
(cherry picked from commit 5248891)

Co-authored-by: Alex Moriarty <alex.moriarty@picknik.ai>
clalancette pushed a commit that referenced this pull request Jun 21, 2023
* Foxy is now EOL

* [EOL] Foxy

- review feedback:
  - mergify config
  - background color
  - add date to date

Official ROS 2 Foxy EOL Date June 20th, 2023

https://twitter.com/OpenRoboticsOrg/status/1666484720585277443

* Remove Foxy from the top-level Releases page.

Signed-off-by: Alex Moriarty <alex.moriarty@picknik.ai>
Signed-off-by: Chris Lalancette <clalancette@gmail.com>
(cherry picked from commit 5248891)

Co-authored-by: Alex Moriarty <alex.moriarty@picknik.ai>
clalancette pushed a commit that referenced this pull request Jun 21, 2023
* Foxy is now EOL

* [EOL] Foxy

- review feedback:
  - mergify config
  - background color
  - add date to date

Official ROS 2 Foxy EOL Date June 20th, 2023

https://twitter.com/OpenRoboticsOrg/status/1666484720585277443

* Remove Foxy from the top-level Releases page.

Signed-off-by: Alex Moriarty <alex.moriarty@picknik.ai>
Signed-off-by: Chris Lalancette <clalancette@gmail.com>
(cherry picked from commit 5248891)

Co-authored-by: Alex Moriarty <alex.moriarty@picknik.ai>
130s pushed a commit to 130s/ros2_documentation that referenced this pull request Jun 29, 2023
* Foxy is now EOL

* [EOL] Foxy

- review feedback:
  - mergify config
  - background color
  - add date to date

Official ROS 2 Foxy EOL Date June 20th, 2023

https://twitter.com/OpenRoboticsOrg/status/1666484720585277443

* Remove Foxy from the top-level Releases page.

Signed-off-by: Alex Moriarty <alex.moriarty@picknik.ai>
Signed-off-by: Chris Lalancette <clalancette@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport-all backport at reviewers discretion; from rolling to all versions
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants