-
Notifications
You must be signed in to change notification settings - Fork 1.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Foxy is now EOL #3700
Foxy is now EOL #3700
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@moriarty thanks for the contribution.
can you add the following changes?
.mergify.yml
foxy backport rule can be removed. (refer to Mark ROS 2 Galactic as end-of-life #3243)ros2_documentation/source/Releases.rst
Line 52 in 6de7fb9
.rst-content tr:nth-child(4) {background-color: #33cc66;} ros2_documentation/source/Releases.rst
Line 109 in 6de7fb9
- May 2023
@cottsay @audrow @Yadunund can you have another review? |
We have not officially EOLed Foxy yet, so we should hold off on this. It is coming soon. |
Why is it not official yet? The original EOL date has passed. |
We haven't done the final sync. The work is in progress. In general, we don't guarantee an EOL date, just have an approximate end. |
I've set the date in that line to the last day of May 2023. https://www.ros.org/reps/rep-2000.html#foxy-fitzroy-may-2020-may-2023 For any projects which want to support current EOL versions this is effects things like resource planning and scheduling, and continuous integration budgets. I understand that the sync sometimes happens when the sync happens and that the last sync can easily get delayed due to Iron, but other non-core ROS 2 projects have already started assuming Foxy is EOL and dropping CI etc |
Yes, that's generally the reason. It's not impossible to do it at the same time as releasing a new release, but it can be hard at times. That was the case this year. |
used GitHub UI to fixup conflicts and remove .rst extension from #3723 |
@clalancette I've updated the date to match https://twitter.com/OpenRoboticsOrg/status/1666484720585277443 |
I Applied your feedback, could you re-review? |
It is June 1 2023 and Foxy has reached EOL Signed-off-by: Alex Moriarty <alex.moriarty@picknik.ai>
- review feedback: - mergify config - background color - add date to date Signed-off-by: Alex Moriarty <alex.moriarty@picknik.ai>
Official ROS 2 Foxy EOL Date June 20th, 2023 https://twitter.com/OpenRoboticsOrg/status/1666484720585277443
Signed-off-by: Chris Lalancette <clalancette@gmail.com>
ec3d6a3
to
557f299
Compare
* Foxy is now EOL * [EOL] Foxy - review feedback: - mergify config - background color - add date to date Official ROS 2 Foxy EOL Date June 20th, 2023 https://twitter.com/OpenRoboticsOrg/status/1666484720585277443 * Remove Foxy from the top-level Releases page. Signed-off-by: Alex Moriarty <alex.moriarty@picknik.ai> Signed-off-by: Chris Lalancette <clalancette@gmail.com> (cherry picked from commit 5248891)
* Foxy is now EOL * [EOL] Foxy - review feedback: - mergify config - background color - add date to date Official ROS 2 Foxy EOL Date June 20th, 2023 https://twitter.com/OpenRoboticsOrg/status/1666484720585277443 * Remove Foxy from the top-level Releases page. Signed-off-by: Alex Moriarty <alex.moriarty@picknik.ai> Signed-off-by: Chris Lalancette <clalancette@gmail.com> (cherry picked from commit 5248891)
@Mergifyio backport foxy |
✅ Backports have been created
|
* Foxy is now EOL * [EOL] Foxy - review feedback: - mergify config - background color - add date to date Official ROS 2 Foxy EOL Date June 20th, 2023 https://twitter.com/OpenRoboticsOrg/status/1666484720585277443 * Remove Foxy from the top-level Releases page. Signed-off-by: Alex Moriarty <alex.moriarty@picknik.ai> Signed-off-by: Chris Lalancette <clalancette@gmail.com> (cherry picked from commit 5248891)
* Foxy is now EOL * [EOL] Foxy - review feedback: - mergify config - background color - add date to date Official ROS 2 Foxy EOL Date June 20th, 2023 https://twitter.com/OpenRoboticsOrg/status/1666484720585277443 * Remove Foxy from the top-level Releases page. Signed-off-by: Alex Moriarty <alex.moriarty@picknik.ai> Signed-off-by: Chris Lalancette <clalancette@gmail.com> (cherry picked from commit 5248891) Co-authored-by: Alex Moriarty <alex.moriarty@picknik.ai>
* Foxy is now EOL * [EOL] Foxy - review feedback: - mergify config - background color - add date to date Official ROS 2 Foxy EOL Date June 20th, 2023 https://twitter.com/OpenRoboticsOrg/status/1666484720585277443 * Remove Foxy from the top-level Releases page. Signed-off-by: Alex Moriarty <alex.moriarty@picknik.ai> Signed-off-by: Chris Lalancette <clalancette@gmail.com> (cherry picked from commit 5248891) Co-authored-by: Alex Moriarty <alex.moriarty@picknik.ai>
* Foxy is now EOL * [EOL] Foxy - review feedback: - mergify config - background color - add date to date Official ROS 2 Foxy EOL Date June 20th, 2023 https://twitter.com/OpenRoboticsOrg/status/1666484720585277443 * Remove Foxy from the top-level Releases page. Signed-off-by: Alex Moriarty <alex.moriarty@picknik.ai> Signed-off-by: Chris Lalancette <clalancette@gmail.com> (cherry picked from commit 5248891) Co-authored-by: Alex Moriarty <alex.moriarty@picknik.ai>
* Foxy is now EOL * [EOL] Foxy - review feedback: - mergify config - background color - add date to date Official ROS 2 Foxy EOL Date June 20th, 2023 https://twitter.com/OpenRoboticsOrg/status/1666484720585277443 * Remove Foxy from the top-level Releases page. Signed-off-by: Alex Moriarty <alex.moriarty@picknik.ai> Signed-off-by: Chris Lalancette <clalancette@gmail.com>
It is June 1 2023 and Foxy has reached EOL