Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add passive voice (rebase) #35

Merged
merged 9 commits into from
Dec 12, 2020
Merged

Add passive voice (rebase) #35

merged 9 commits into from
Dec 12, 2020

Conversation

nerixim
Copy link
Collaborator

@nerixim nerixim commented Dec 8, 2020

Addressed comment at #27 (comment)

@nerixim
Copy link
Collaborator Author

nerixim commented Dec 8, 2020

@rossmeissl
I've rebased and changed the wording.
Github Action failed to install Ruby https://github.com/rossmeissl/verbs/pull/35/checks?sha=261ea39ca3434b863aa25a2cda9b59d820649b9d so I tried upgrading actions/setup Ruby but it stopped working altogether.
Maybe try switching to https://github.com/ruby/setup-ruby as proposed at actions/setup-ruby#80?

@rossmeissl
Copy link
Owner

Hi @nerixim I just added you as a collaborator on this repo — does that allow you to make the fix yourself? If not I can try to do it myself just might take a bit longer. Thanks!

@nerixim
Copy link
Collaborator Author

nerixim commented Dec 11, 2020

@rossmeissl Thanks! Turned out it was an indent problem 🤦

rossmeissl
rossmeissl approved these changes Dec 11, 2020
View reviewed changes
Copy link
Owner

@rossmeissl rossmeissl left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @nerixim thank you!
Please add yourself to the Acknowledgements section of the Readme (unless you'd rather not be there) and then go ahead and merge!

I really appreciate your help!

@nerixim nerixim merged commit 3210ce3 into rossmeissl:master Dec 12, 2020
@rossmeissl
Copy link
Owner

This closes #27 — thank you @jeidsath for your early work on this.

I've released the new passive voice feature in 2.3.0.

Thanks again @nerixim !

@rossmeissl rossmeissl mentioned this pull request Dec 14, 2020
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rossmeissl rossmeissl rossmeissl approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@nerixim @rossmeissl @jeidsath