Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add table-transformer like baseline #61

Merged
merged 1 commit into from
Mar 15, 2023
Merged

Add table-transformer like baseline #61

merged 1 commit into from
Mar 15, 2023

Conversation

nimral
Copy link

@nimral nimral commented Mar 14, 2023

I verified that the trianings run for a few epochs, but not that they finish and give the same results as before.

@nimral nimral requested a review from simsa-st March 14, 2023 15:53
simsa-st
simsa-st reviewed Mar 14, 2023
View reviewed changes
Copy link
Member

@simsa-st simsa-st left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, just a few small comments. Can you afterwards also squash the commits into one (or few meaningful if you'd like) to have a clean history in main?

baselines/table-transformer/README.md Show resolved Hide resolved
baselines/table-transformer/README.md Show resolved Hide resolved
baselines/table-transformer/base_config.yaml Show resolved Hide resolved
pyproject.toml Outdated Show resolved Hide resolved
baselines/table-transformer/README.md Show resolved Hide resolved
simsa-st
simsa-st approved these changes Mar 15, 2023
View reviewed changes
Copy link
Member

@simsa-st simsa-st left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All good, thanks a lot for the cleanup!

@simsa-st simsa-st merged commit 9da2379 into main Mar 15, 2023
@simsa-st simsa-st deleted the mkocian-table-transformer branch March 15, 2023 12:14
@nimral
Copy link
Author

nimral commented Mar 15, 2023

Thanks for the help! :-)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@simsa-st simsa-st simsa-st approved these changes

Assignees

@simsa-st simsa-st

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@nimral @simsa-st