Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support splits with no annotations #66

Merged
merged 2 commits into from
Apr 25, 2023

Conversation

simsa-st
Copy link
Member

The inference scripts still fail at the end since they try to run the evaluation. This happens only after the predictions are computed and stored so it doesn't cause any (practical) problems.

@simsa-st simsa-st requested a review from sulc April 25, 2023 14:07
Copy link

@sulc sulc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, one proposal (not necessary).
I didn't test the updated scripts, assuming you did/do, @simsa-st.

docile/tools/dataset_browser.py Show resolved Hide resolved
@simsa-st
Copy link
Member Author

Yes, I tested it works (giving the same results as before). As I said, it still crashes at the end when it tries to run the evaluation but the generated predictions are ok.

@simsa-st simsa-st merged commit db5c50e into main Apr 25, 2023
@simsa-st simsa-st deleted the sts-support-split-with-no-annotations branch April 25, 2023 14:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants