Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

rhel-9.5: Fix for RHEL-1454 #1663

Merged
merged 2 commits into from
May 20, 2024

Conversation

ppisar
Copy link
Contributor

@ppisar ppisar commented May 16, 2024

Upstream commit: 90d2ffa
Upstream commit: 85432df
Resolves: https://issues.redhat.com/browse/RHEL-1454
Tests: rpm-software-management/ci-dnf-stack#1507

@kontura, could you please review this backport for rhel-9.5 of your upstream commits?

Upstream commit: 85432df

`rpmtsAddInstallElement()` doesn't work for all reinstall cases, such as
when a package `Provides` and `Conflicts` with the same capability.

Fixes: rpm-software-management/microdnf#137
Resolves: https://issues.redhat.com/browse/RHEL-1454
Upstream commit: bc37168

It calls callbacks for `RPMCALLBACK_INST_START` and
`RPMCALLBACK_INST_PROGRESS` just like before when the reinstall was done
through regural install (rpmtsAddInstallElement) but in addition it also
calls `RPMCALLBACK_UNINST_START` and `RPMCALLBACK_UNINST_PROGRESS`. To
ensure they find the `DnfPackage` add it to `remove_helper` array.

Unfortunaly this means that the reinstall action is reported twice to
the clients (one install and one uninstall). We could try to hide one of
the them but I think a better solution is to report what is actually
happening and report one install and one uninstall.

This is for the context part of libdnf (microdnf, packagekit, ...)

Fixes: rpm-software-management#1653
Resolves: https://issues.redhat.com/browse/RHEL-1454
@kontura kontura merged commit 7a3d4ed into rpm-software-management:rhel-9.5 May 20, 2024
2 of 3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

2 participants