Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

TypeScript: Remove any types / improve type definitions #3414

Merged
merged 25 commits into from
Jun 14, 2021
Merged

TypeScript: Remove any types / improve type definitions #3414

merged 25 commits into from
Jun 14, 2021

Conversation

schloerke
Copy link
Collaborator

@schloerke schloerke commented Jun 10, 2021 •
edited
Loading

Question

@schloerke
Remove unused variables
137a416
@schloerke
Add type to text input binding setValue(value) arg.
2351025
@schloerke
Use a CoordmapInitType to distinguish between pre/post-inited coordma…
208b3bf 
…p objs
@schloerke
State that the el is an HTML element and only check for .tagName if…
813e1e4 
… it is an instance of HTMLElement
@schloerke
Fix singletons and reconnectDialog module boundary types
b384dc9
@schloerke
The where position does not agree with the jquery implementation
1223ae3
@schloerke
Type HtmlDependencies
a294c49
@schloerke
More boundary arg types
ab1307b
@schloerke
Do not restrict the message's message value to a subset of shiny mess…
70111d2 
…age objects
@schloerke
Fix type within _equal() given the x and y are objects
274d512
@schloerke
With no more warnings, make module boundary types errors
80973da
@schloerke
Make any types a warning
a1bcdbb
@schloerke
Remove checkbox and checkboxgroup any types
094c90f
@schloerke
Default the return types of getValue and getState to unknown
f9a6f29
@schloerke
Remove any types from date input binding
52a9575
@schloerke
Fix input binding number, radio, and selectInput any types
2eea313
@schloerke
Update text input binding to remove more any types
0288f47
@schloerke
Use Infinity placeholder of 1e9999 for daterange input binding
732b144
@schloerke
Remove more any types
088e056
@schloerke
Move where type definition up. This should be addressed!
cc7d3ca
@schloerke
Fix debounce, invoke, and throttle handlers any types. Yay generics
54ebc55
@schloerke
Remove more any types
a312136
@schloerke
Throw an error if any explicit any types are used
ea1f8f7
@schloerke
More any types
498fe5e
@schloerke
build
43d3682
@schloerke schloerke requested review from wch and nstrayer June 10, 2021 18:24
@schloerke schloerke mentioned this pull request Jun 14, 2021
Closed
@schloerke schloerke merged commit 1dd256b into master Jun 14, 2021
@schloerke schloerke deleted the more_types branch June 14, 2021 18:22
schloerke added a commit that referenced this pull request Jun 15, 2021
@schloerke
Merge branch 'master' into ts_unit
936f985 
* master:
  Move `./srcts` configs to top level to support types installation from GitHub (#3425)
  insertTab() now handles position correctly when target is NULL (#3404)
  yarn add node-gyp; yarn build (#3424)
  Export TypeScript type definitions to local folder (#3418)
  TypeScript: Remove `any` types / improve type definitions (#3414)
  Better color constrasting in sliderInput() (#3366)
  Use ggplot2::get_alt_text() if available to provide better default alt text (#3398)
  Set selectize dropdownParent to "body" to prevent clipping
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@wch wch wch approved these changes

@nstrayer nstrayer Awaiting requested review from nstrayer

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@schloerke @wch