Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Nodoc for recurse_proc #442

Merged
merged 1 commit into from
Jul 31, 2020
Merged

Nodoc for recurse_proc #442

merged 1 commit into from
Jul 31, 2020

Conversation

BurdetteLamar
Copy link
Member

Suggest :nodoc: for method recurse_proc. It's called only (and optionally) by method load, and may not be useful to JSON users.

If we don't :nodoc: this method, it should at least have some tests, which I think are now lacking.

@BurdetteLamar
Copy link
Member Author

@marcandre, does this seem right to you?

@marcandre
Copy link
Member

Mmm, that method is public but not clearly related to json.

Marking it as :nodoc: seems reasonable to me.

@BurdetteLamar
Copy link
Member Author

@hsbt, can you take a look?

@BurdetteLamar
Copy link
Member Author

Same for JSNONiconv and JSON.valid_utf8?, yes? If so, please mod here.

@hsbt hsbt merged commit e7cf232 into ruby:master Jul 31, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants