Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Suppress inline is not at beginning of declaration for melt_array #2050

Merged

Conversation

S-H-GAMELINKS
Copy link
Contributor

function

When building RBS on Ubuntu 22.04 and GCC 11.4.0, the following warning appeared.
And this change has suppressed warning.

+ bundle exec rake compile
mkdir -p tmp/x86_64-linux/rbs_extension/3.4.0
cd tmp/x86_64-linux/rbs_extension/3.4.0
/home/sh/.rbenv/versions/ruby-dev/bin/ruby -I. ../../../../ext/rbs_extension/extconf.rb
checking for whether -std=gnu99 is accepted as CFLAGS... yes
creating Makefile
cd -
cd tmp/x86_64-linux/rbs_extension/3.4.0
/usr/bin/gmake
compiling ../../../../ext/rbs_extension/constants.c
compiling ../../../../ext/rbs_extension/lexer.c
compiling ../../../../ext/rbs_extension/lexstate.c
compiling ../../../../ext/rbs_extension/location.c
compiling ../../../../ext/rbs_extension/main.c
compiling ../../../../ext/rbs_extension/parser.c
../../../../ext/rbs_extension/parser.c:57:1: warning: ‘inline’ is not at beginning of declaration [-Wold-style-declaration]
   57 | static void inline melt_array(VALUE *array) {
      | ^~~~~~
cc1: note: unrecognized command-line option ‘-Wno-self-assign’ may have been intended to silence earlier diagnostics
cc1: note: unrecognized command-line option ‘-Wno-parentheses-equality’ may have been intended to silence earlier diagnostics
cc1: note: unrecognized command-line option ‘-Wno-constant-logical-operand’ may have been intended to silence earlier diagnostics
compiling ../../../../ext/rbs_extension/parserstate.c
compiling ../../../../ext/rbs_extension/ruby_objs.c
compiling ../../../../ext/rbs_extension/unescape.c
linking shared-object rbs_extension.so
cd -
mkdir -p tmp/x86_64-linux/stage/lib
/usr/bin/gmake install sitearchdir=../../../../lib sitelibdir=../../../../lib target_prefix=
/usr/bin/install -c -m 0755 rbs_extension.so ../../../../lib
cp tmp/x86_64-linux/rbs_extension/3.4.0/rbs_extension.so tmp/x86_64-linux/stage/lib/rbs_extension.so
+ type re2c
+ echo '🚨 Cannot find re2c, which is required to generate lexer. Install the tool to change the lexer.'
🚨 Cannot find re2c, which is required to generate lexer. Install the tool to change the lexer.

function

When building RBS on Ubuntu 22.04 and GCC 11.4.0, the following warning appeared.
And this change has suppressed warning.

warning: 'inline' is not at the beginning of declaration [-Wold-style-declaration].
   57 | static void inline melt_array(VALUE *array) {
      | ^~~~~~
@soutaro soutaro added this pull request to the merge queue Oct 7, 2024
@soutaro soutaro added this to the RBS 3.7 milestone Oct 7, 2024
Copy link
Member

@soutaro soutaro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

Merged via the queue into ruby:master with commit fc3c07f Oct 7, 2024
18 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

2 participants