Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix UntypedFunction does not provide #map_type_name #2054

Merged
merged 1 commit into from
Oct 8, 2024
Merged

Fix UntypedFunction does not provide #map_type_name #2054

merged 1 commit into from
Oct 8, 2024

Conversation

tk0miya
Copy link
Contributor

@tk0miya tk0miya commented Oct 7, 2024

@tk0miya
Copy link
Contributor Author

tk0miya commented Oct 7, 2024

I found the type definition of #map_type_name. But there is no implementation...
https://github.com/ruby/rbs/blob/v3.6.1/sig/types.rbs#L476

@tk0miya tk0miya mentioned this pull request Oct 7, 2024
Open
@soutaro soutaro added this to the RBS 3.7 milestone Oct 8, 2024
soutaro
soutaro approved these changes Oct 8, 2024
View reviewed changes
Copy link
Member

@soutaro soutaro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🙇‍♂️

@soutaro soutaro added this pull request to the merge queue Oct 8, 2024
Merged via the queue into ruby:master with commit a877d7d Oct 8, 2024
18 checks passed
@tk0miya tk0miya deleted the bugs/UntypedFunction.map_type_name branch October 8, 2024 02:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@soutaro soutaro soutaro approved these changes

Assignees
No one assigned
Labels
None yet
Milestone
RBS 3.7
Development

Successfully merging this pull request may close these issues.
2 participants
@tk0miya @soutaro