Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix Tk::Text#count not sending arguments to tcl. #15

Merged
merged 1 commit into from
May 21, 2018
Merged

Fix Tk::Text#count not sending arguments to tcl. #15

merged 1 commit into from
May 21, 2018

Conversation

iamvain
Copy link
Contributor

@iamvain iamvain commented Apr 29, 2018

No description provided.

@yuki24
Copy link
Member

yuki24 commented May 21, 2018

Thanks for your PR. Could you add a test that covers your change?

@amatsuda
Copy link
Member

@yuki24 Great review basically... but how can one add a test for this repo? 🤔

@yuki24
Copy link
Member

yuki24 commented May 21, 2018 •
edited
Loading

😳💥

@amatsuda
Copy link
Member

Actually I’ll blindly merge this, because this fix seems to be obviously fixing a silly mistake.

@amatsuda amatsuda merged commit 58ac941 into ruby:master May 21, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@iamvain @yuki24 @amatsuda