Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revive skipped spec/system/case_court_reports/index_spec #5797

Merged
merged 1 commit into from
May 31, 2024

Conversation

solebared
Copy link
Collaborator

@solebared solebared commented May 31, 2024

What github issue is this PR for, if any?

Resolves #5671.
Resloves part of #5727 .

What changed, and why?

  1. Spec seems to have gotten out of date -- need to first click through to the modal.
  2. Switch to use have_css matcher instead of find().to match

Feelings gif (optional)

ruby for good

1. Spec seems to have gotten out of date -- need to first click through
   to the modal
2. Switch to use have_css matcher instead of find().to match
@github-actions github-actions bot added ruby Pull requests that update Ruby code Tests! 🎉💖👏 labels May 31, 2024
@solebared solebared changed the title Revive failing spec in system/case_court_reports/index_spec Revive skipped spec/system/case_court_reports/index_spec May 31, 2024
Copy link
Collaborator

@compwron compwron left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice!

@compwron compwron merged commit b36ee99 into main May 31, 2024
17 of 19 checks passed
@compwron compwron deleted the solebared/xits/case_court_reports/index/5671 branch May 31, 2024 20:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ruby Pull requests that update Ruby code Tests! 🎉💖👏
Projects
None yet
2 participants