Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Unskip and improve specs marked as flaky in system/volunteers/index_spec #5798

Merged
merged 3 commits into from
Jun 1, 2024
Merged

Unskip and improve specs marked as flaky in system/volunteers/index_spec #5798

merged 3 commits into from
Jun 1, 2024

Commits on May 31, 2024

  1. Uncomment specs to unearth flakes in CI 

    Note: also removed all forced `wait:`s.
    @solebared
    solebared committed May 31, 2024
    Configuration menu
    Copy the full SHA
    76e7378 View commit details
    Browse the repository at this point in the history

  2. Switch to using have_button matcher 

    Likely more robust, though i didn't actually encounter any
flakiness here. Mostly just addressing the TODO comment.
    @solebared
    solebared committed May 31, 2024
    Configuration menu
    Copy the full SHA
    a2467d4 View commit details
    Browse the repository at this point in the history

  3. Grabbag of changes to mitigate possible flakiness 

    Mostly converting find-then-check occurences to use capybara matchers
instead.
    @solebared
    solebared committed May 31, 2024
    Configuration menu
    Copy the full SHA
    3f993ee View commit details
    Browse the repository at this point in the history