Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

rollback transaction if destroy aborted (fix #484) #485

Merged
merged 3 commits into from
Mar 23, 2022

Conversation

Able1991
Copy link
Contributor

No description provided.

mathieujobin
mathieujobin previously approved these changes Jan 19, 2022
Copy link
Collaborator

@mathieujobin mathieujobin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this actually looks like an important fix.
please update changelog with current format and rebase with core so we can see all tests passes

@mathieujobin mathieujobin merged commit f8cffd8 into rubysherpas:core Mar 23, 2022
karunkumar1ly pushed a commit to edcast/paranoia that referenced this pull request Feb 6, 2024
Co-authored-by: Boris <penkovskiy@taxi21.ru>
Co-authored-by: Mathieu Jobin <mathieujobin@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Rollback is not called if destroy fails
2 participants