Warn if acts_as_paranoid is called more than once on the same model #492
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mathieujobin
approved these changes
Nov 10, 2021
mathieujobin
approved these changes
Jan 19, 2022
There was a problem hiding this comment.
This seems like a good idea... I wonder if my huge platform would be bitten by this...
I'd be temped to switch the puts for a raise if Rails.env.test?
anyone else have an opinion on this?
I could include it in an upcoming release.
but needs version bump, changelog updated and rebased with core for tests to run.
ignatiusreza
changed the title
ignatiusreza
force-pushed
the
double-paranoia
branch
2 times, most recently
from
ffd2eeb
to
36bf837
Compare
which will breaks the method aliasing of `#destroy` and makes them lost access to the original one defined by ActiveRecord
ignatiusreza
force-pushed
the
double-paranoia
branch
from
36bf837
to
1bee49e
Compare
|
I rebased and added changelog Given that paranoia is designed to be usable with activerecord outside of rails, I'm not quite sure how to best check for the rails environment. Any advice? |
|
to answer your last question @ignatiusreza I recommend doing |
karunkumar1ly
pushed a commit
to edcast/paranoia
that referenced
this pull request
Feb 6, 2024
…ubysherpas#492) which will breaks the method aliasing of `#destroy` and makes them lost access to the original one defined by ActiveRecord
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
which will breaks the method aliasing of
#destroyand makes them lostaccess to the original one defined by ActiveRecord
fix #489