This repository has been archived by the owner on Apr 25, 2024. It is now read-only.
Kill kore-rpc with SIGINT instead of SIGTERM
#298
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ehildenb
approved these changes
Mar 24, 2023
|
Thanks for changing this! Besides the issues with remaining temporary directories, we also could not get profiling data from the back-end when it was killed forcefully. Using |
rv-jenkins
pushed a commit
that referenced
this pull request
Mar 28, 2024
Closes runtimeverification/kontrol#375. Related: #298, #317 Using `SIGINT` or a [SIGTERM handler](runtimeverification/hs-backend-booster@bc7c1b0) causes some sort of a deadlock in the booster, making Kontrol hang. Based on our experiments, switching to `SIGTERM` seems to fix this issue. The disadvantage, as mentioned by @goodlyrottenapple and @jberthold, is that we won't get the SMT transcript or any other logs that haven't been flushed to file when the SIGTERM is received; however, it would address a major usability issue in view of the upcoming workshop next week, at least as a temporary solution. --------- Co-authored-by: devops <devops@runtimeverification.com>
PetarMax
pushed a commit
that referenced
this pull request
Mar 28, 2024
Closes runtimeverification/kontrol#375. Related: #298, #317 Using `SIGINT` or a [SIGTERM handler](runtimeverification/hs-backend-booster@bc7c1b0) causes some sort of a deadlock in the booster, making Kontrol hang. Based on our experiments, switching to `SIGTERM` seems to fix this issue. The disadvantage, as mentioned by @goodlyrottenapple and @jberthold, is that we won't get the SMT transcript or any other logs that haven't been flushed to file when the SIGTERM is received; however, it would address a major usability issue in view of the upcoming workshop next week, at least as a temporary solution. --------- Co-authored-by: devops <devops@runtimeverification.com>
Baltoli
pushed a commit
to runtimeverification/k
that referenced
this pull request
Apr 9, 2024
Closes runtimeverification/kontrol#375. Related: runtimeverification/pyk#298, runtimeverification/pyk#317 Using `SIGINT` or a [SIGTERM handler](runtimeverification/hs-backend-booster@bc7c1b0) causes some sort of a deadlock in the booster, making Kontrol hang. Based on our experiments, switching to `SIGTERM` seems to fix this issue. The disadvantage, as mentioned by @goodlyrottenapple and @jberthold, is that we won't get the SMT transcript or any other logs that haven't been flushed to file when the SIGTERM is received; however, it would address a major usability issue in view of the upcoming workshop next week, at least as a temporary solution. --------- Co-authored-by: devops <devops@runtimeverification.com>
Baltoli
pushed a commit
to runtimeverification/k
that referenced
this pull request
Apr 9, 2024
…on/pyk#298) Workaround for runtimeverification/haskell-backend#3557 --------- Co-authored-by: devops <devops@runtimeverification.com>
Baltoli
pushed a commit
to runtimeverification/k
that referenced
this pull request
Apr 9, 2024
Closes runtimeverification/kontrol#375. Related: runtimeverification/pyk#298, runtimeverification/pyk#317 Using `SIGINT` or a [SIGTERM handler](runtimeverification/hs-backend-booster@bc7c1b0) causes some sort of a deadlock in the booster, making Kontrol hang. Based on our experiments, switching to `SIGTERM` seems to fix this issue. The disadvantage, as mentioned by @goodlyrottenapple and @jberthold, is that we won't get the SMT transcript or any other logs that haven't been flushed to file when the SIGTERM is received; however, it would address a major usability issue in view of the upcoming workshop next week, at least as a temporary solution. --------- Co-authored-by: devops <devops@runtimeverification.com>
Baltoli
pushed a commit
to runtimeverification/k
that referenced
this pull request
Apr 9, 2024
…on/pyk#298) Workaround for runtimeverification/haskell-backend#3557 --------- Co-authored-by: devops <devops@runtimeverification.com>
Baltoli
pushed a commit
to runtimeverification/k
that referenced
this pull request
Apr 9, 2024
Closes runtimeverification/kontrol#375. Related: runtimeverification/pyk#298, runtimeverification/pyk#317 Using `SIGINT` or a [SIGTERM handler](runtimeverification/hs-backend-booster@bc7c1b0) causes some sort of a deadlock in the booster, making Kontrol hang. Based on our experiments, switching to `SIGTERM` seems to fix this issue. The disadvantage, as mentioned by @goodlyrottenapple and @jberthold, is that we won't get the SMT transcript or any other logs that haven't been flushed to file when the SIGTERM is received; however, it would address a major usability issue in view of the upcoming workshop next week, at least as a temporary solution. --------- Co-authored-by: devops <devops@runtimeverification.com>
Baltoli
pushed a commit
to runtimeverification/k
that referenced
this pull request
Apr 10, 2024
…on/pyk#298) Workaround for runtimeverification/haskell-backend#3557 --------- Co-authored-by: devops <devops@runtimeverification.com>
Baltoli
pushed a commit
to runtimeverification/k
that referenced
this pull request
Apr 10, 2024
Closes runtimeverification/kontrol#375. Related: runtimeverification/pyk#298, runtimeverification/pyk#317 Using `SIGINT` or a [SIGTERM handler](runtimeverification/hs-backend-booster@bc7c1b0) causes some sort of a deadlock in the booster, making Kontrol hang. Based on our experiments, switching to `SIGTERM` seems to fix this issue. The disadvantage, as mentioned by @goodlyrottenapple and @jberthold, is that we won't get the SMT transcript or any other logs that haven't been flushed to file when the SIGTERM is received; however, it would address a major usability issue in view of the upcoming workshop next week, at least as a temporary solution. --------- Co-authored-by: devops <devops@runtimeverification.com>
Baltoli
pushed a commit
to runtimeverification/k
that referenced
this pull request
Apr 10, 2024
…on/pyk#298) Workaround for runtimeverification/haskell-backend#3557 --------- Co-authored-by: devops <devops@runtimeverification.com>
Baltoli
pushed a commit
to runtimeverification/k
that referenced
this pull request
Apr 10, 2024
Closes runtimeverification/kontrol#375. Related: runtimeverification/pyk#298, runtimeverification/pyk#317 Using `SIGINT` or a [SIGTERM handler](runtimeverification/hs-backend-booster@bc7c1b0) causes some sort of a deadlock in the booster, making Kontrol hang. Based on our experiments, switching to `SIGTERM` seems to fix this issue. The disadvantage, as mentioned by @goodlyrottenapple and @jberthold, is that we won't get the SMT transcript or any other logs that haven't been flushed to file when the SIGTERM is received; however, it would address a major usability issue in view of the upcoming workshop next week, at least as a temporary solution. --------- Co-authored-by: devops <devops@runtimeverification.com>
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Workaround for runtimeverification/haskell-backend#3557