Use slice::iter instead of into_iter to avoid future breakage
#162
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
`an_array.into_iter()` currently just works because of the autoref feature, which then calls `<[T] as IntoIterator>::into_iter`. But in the future, arrays will implement `IntoIterator`, too. In order to avoid problems in the future, the call is replaced by `iter()` which is shorter and more explicit.
|
This seems reasonable to me, it's probably inevitable that we'd need to track small patches to minor releases. I've gone ahead and set up a |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
lazy_static1.1.0 is already quite old, but for some reason some creates have a~1.1.0version requirement. As a consequence, quite a few crates still havelazy_static1.1.0 in their dependency tree. That particular version regresses with rust-lang/rust#65819, asarray.into_iter()is used in the build script. This report says thatlazy_static1.1.0 causes roughly 800 other crates to regress.Ideally all crates would upgrade to a newer
lazy_static, but that might now happen. Therefore my idea: release1.1.1with this tiny change. It does not require a newer Rust compiler version and fixes a bunch of crates. What do you think?(PS: the PR targeting
masteris obviously wrong. I just wanted to create this PR for some discussion about this. If everyone agrees we should release1.1.1, I can manually "merge" this into the main repo)