-
Notifications
You must be signed in to change notification settings - Fork 3.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
More edits to the async chapter #4033
base: only-new-async
Are you sure you want to change the base?
Commits on Aug 24, 2024
-
- Set their view boxes to the original height and width, so they are guaranteed to present correctly. - For Figure 17-02, use the trick of adding a hidden node and hidden arrow to it in “Task 2” to align the two boxes.
Configuration menu - View commit details
-
Copy full SHA for a42f27b - Browse repository at this point
Copy the full SHA a42f27bView commit details -
Configuration menu - View commit details
-
Copy full SHA for f812ed0 - Browse repository at this point
Copy the full SHA f812ed0View commit details
Commits on Aug 30, 2024
-
Configuration menu - View commit details
-
Copy full SHA for c648c0e - Browse repository at this point
Copy the full SHA c648c0eView commit details
Commits on Aug 31, 2024
-
Configuration menu - View commit details
-
Copy full SHA for ef4a518 - Browse repository at this point
Copy the full SHA ef4a518View commit details
Commits on Sep 3, 2024
-
Ch. 17: start restructuring chapter
- Create a section (which will be deleted or at least reintegrated once all is said and done) to hold content pulled out of other sections for the sake of clearer flow and understanding. - Pull “advanced” material from 17.00, 17.01, and 17.02 into the holding section and start reorganizing their content to account for shifting around materials.
Configuration menu - View commit details
-
Copy full SHA for 1de14c8 - Browse repository at this point
Copy the full SHA 1de14c8View commit details
Commits on Sep 11, 2024
-
In addition to the baseline changes, skip over non-directory code where directories are needed to deal with things like `.DS_Store` files. Also add a bunch of context on error causes from `std::io::Error` because it was *impossible* to figure out exactly what the source of those were.
Configuration menu - View commit details
-
Copy full SHA for 6b6b450 - Browse repository at this point
Copy the full SHA 6b6b450View commit details -
Merge pull request #4031 from rust-lang/rust-1.81
Upgrade to Rust 1.81
Configuration menu - View commit details
-
Copy full SHA for 589ce6b - Browse repository at this point
Copy the full SHA 589ce6bView commit details -
Configuration menu - View commit details
-
Copy full SHA for 299fd1f - Browse repository at this point
Copy the full SHA 299fd1fView commit details -
Merge pull request #4024 from bin-wang/remove-mut
Use immutable borrow of `TcpStream` when creating `BufReader`
Configuration menu - View commit details
-
Copy full SHA for 28a2444 - Browse repository at this point
Copy the full SHA 28a2444View commit details -
Merge pull request #4025 from ficcialfaint/cargo-init
Add `cargo init` usage suggestion to 1.3
Configuration menu - View commit details
-
Copy full SHA for e2b7246 - Browse repository at this point
Copy the full SHA e2b7246View commit details -
Configuration menu - View commit details
-
Copy full SHA for d5932d2 - Browse repository at this point
Copy the full SHA d5932d2View commit details
Commits on Sep 12, 2024
-
Merge pull request #4032 from rust-lang/updated-build-instructions
Update build instructions: include mdbook plugins
Configuration menu - View commit details
-
Copy full SHA for 2b07207 - Browse repository at this point
Copy the full SHA 2b07207View commit details -
Ch. 17: rename
trpl::block_on
totrpl::run
The `block_on` name is what both Tokio and smol use, but it is a bit obscure from the point of view of introducing this material. `run` says much more clearly what it does *for the level we care about here*, I think.
Configuration menu - View commit details
-
Copy full SHA for c552952 - Browse repository at this point
Copy the full SHA c552952View commit details -
Ch. 17: more edits for first three sections
These make up *most* of the rest of the edits I caught while rereading which are not *major structural revisions*, along with some of the bits required for those major structural revisions.
Configuration menu - View commit details
-
Copy full SHA for cd12a1e - Browse repository at this point
Copy the full SHA cd12a1eView commit details -
Configuration menu - View commit details
-
Copy full SHA for 487c81d - Browse repository at this point
Copy the full SHA 487c81dView commit details -
Configuration menu - View commit details
-
Copy full SHA for 9b13b95 - Browse repository at this point
Copy the full SHA 9b13b95View commit details -
Configuration menu - View commit details
-
Copy full SHA for 3cfdf2d - Browse repository at this point
Copy the full SHA 3cfdf2dView commit details -
Ch. 17: rework 17.04 with my own edits and analysis
This does *not* yet incorporate any of the relevant feedback from Carol on this, so a couple spots are still pretty messy.
Configuration menu - View commit details
-
Copy full SHA for 97902d5 - Browse repository at this point
Copy the full SHA 97902d5View commit details -
Ch. 17: rework 17.05 with my own edits and analysis
Along with the wording and phrasing-level edits, pull out a fair bit of material for the “advanced” section at the end, specifically the details of what `Stream` and `StreamExt` actually do.
Configuration menu - View commit details
-
Copy full SHA for 68049c6 - Browse repository at this point
Copy the full SHA 68049c6View commit details -
Configuration menu - View commit details
-
Copy full SHA for 0d8da8b - Browse repository at this point
Copy the full SHA 0d8da8bView commit details -
Configuration menu - View commit details
-
Copy full SHA for 7da825f - Browse repository at this point
Copy the full SHA 7da825fView commit details -
Configuration menu - View commit details
-
Copy full SHA for 6bdf1b7 - Browse repository at this point
Copy the full SHA 6bdf1b7View commit details -
Ch. 17: integrate a number of the outstanding review comments
Bonus: fix some style guide issues, too! Co-authored-by: Carol (Nichols || Goulding) <carol.nichols@gmail.com> Co-authored-by: James Munns <james@onevariable.com> Co-authored-by: Tim McNamara <paperless@timmcnamara.co.nz>
Configuration menu - View commit details
-
Copy full SHA for 1d3517c - Browse repository at this point
Copy the full SHA 1d3517cView commit details -
Ch. 17: address the rest of James’ review comments 🎉
Co-authored-by: James Munns <james@onevariable.com>
Configuration menu - View commit details
-
Copy full SHA for c4d02bf - Browse repository at this point
Copy the full SHA c4d02bfView commit details
Commits on Sep 13, 2024
-
Configuration menu - View commit details
-
Copy full SHA for c35b7d9 - Browse repository at this point
Copy the full SHA c35b7d9View commit details -
Ch. 17: address Tim and Carol's outstanding comments
Co-authored-by: Tim McNamara <paperless@timmcnamara.co.nz> Co-authored-by: Carol (Nichols || Goulding) <carol.nichols@gmail.com>
Configuration menu - View commit details
-
Copy full SHA for 453247c - Browse repository at this point
Copy the full SHA 453247cView commit details -
Configuration menu - View commit details
-
Copy full SHA for ccafd06 - Browse repository at this point
Copy the full SHA ccafd06View commit details
Commits on Sep 16, 2024
-
Remove duplicate integration test from root
I accidentally copied these in when pulling in the `trpl-note` mdbook preprocessor many months ago, and we did not notice amidst the many other changes in that PR!
Configuration menu - View commit details
-
Copy full SHA for 6f5773e - Browse repository at this point
Copy the full SHA 6f5773eView commit details
Commits on Sep 20, 2024
-
Ch. 17: rewrite 17.01 with a better example
Add `reqwest` and `scraper` dependencies to the `trpl` crate. Wrap them in `trpl` re-exports which keep the API surface low. Rewrite the whole first section to use `race` along with those `trpl` re-exports to show a more “real” example of async code right form the start, including actual concurrency, unlike the previous introduction. Update 17.03 to account for having introduced `race` already, and update listing numbers for rewritten 17.01.
Configuration menu - View commit details
-
Copy full SHA for 5b75c32 - Browse repository at this point
Copy the full SHA 5b75c32View commit details