Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

New build-plan tests failing when compiled with rust #5536

Closed
ehuss opened this issue May 15, 2018 · 0 comments · Fixed by #5540
Closed

New build-plan tests failing when compiled with rust #5536

ehuss opened this issue May 15, 2018 · 0 comments · Fixed by #5540

Comments

@ehuss
Copy link
Contributor

ehuss commented May 15, 2018 •
edited
Loading

When attempting to update Cargo in the rust repo, the following tests failed:

    build_plan::cargo_build_plan_build_script
    build_plan::cargo_build_plan_simple
    build_plan::cargo_build_plan_single_dep

Detailed output can be found here: https://ci.appveyor.com/project/rust-lang/rust/build/1.0.7409/job/s65ul0p5xdw9420o

Essentially the problem is that in the rust tree, cargo tests are run with CARGO_TARGET_DIR set, and the above tests do not take that into consideration.

cc @mshal
@ehuss ehuss mentioned this issue May 15, 2018
Closed
ehuss added a commit to ehuss/cargo that referenced this issue May 15, 2018
@ehuss
Fix tests when CARGO_TARGET_DIR is set.
7318014 
Fixes rust-lang#5536
@ehuss ehuss mentioned this issue May 15, 2018
Merged
bors added a commit that referenced this issue May 15, 2018
@bors
Auto merge of #5540 - ehuss:fix-build-plan-tests, r=alexcrichton
f352115 
Fix tests when CARGO_TARGET_DIR is set.

Fixes #5536
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fix tests when CARGO_TARGET_DIR is set. ehuss/cargo
1 participant
@ehuss