Don't re-look-up tables to avoid dots problem #2787
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
If a `links` value has a `.` in the name Cargo would previously panic, but this alters the code to be more principled about lookup in tables to ensure that we don't misinterpret the names. Closes rust-lang#2786
|
r? @wycats (rust_highfive has picked a reviewer for you, use r? to override) |
|
r? @brson |
|
@bors r+ |
|
📌 Commit 53b7422 has been approved by |
bors
added a commit
that referenced
this pull request
Jun 17, 2016
Don't re-look-up tables to avoid dots problem If a `links` value has a `.` in the name Cargo would previously panic, but this alters the code to be more principled about lookup in tables to ensure that we don't misinterpret the names. Closes #2786
|
☀️ Test successful - cargo-cross-linux, cargo-linux-32, cargo-linux-64, cargo-mac-32, cargo-mac-64, cargo-win-gnu-32, cargo-win-gnu-64, cargo-win-msvc-32, cargo-win-msvc-64 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If a
linksvalue has a.in the name Cargo would previously panic, but thisalters the code to be more principled about lookup in tables to ensure that we
don't misinterpret the names.
Closes #2786