Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Always pass -C metadata to the compiler #2946

Merged
merged 1 commit into from
Aug 2, 2016

Conversation

alexcrichton
Copy link
Member

If it's not otherwise available we just key it off the pkgid which should be
unique enough across compilations. This should help incremental compilation
efforts be "more incremental" across projects.

Closes #2943

If it's not otherwise available we just key it off the pkgid which should be
unique enough across compilations. This should help incremental compilation
efforts be "more incremental" across projects.

Closes rust-lang#2943
@rust-highfive
Copy link

@alexcrichton: no appropriate reviewer found, use r? to override

@alexcrichton
Copy link
Member Author

r? @brson

@brson
Copy link
Contributor

brson commented Aug 2, 2016

@bors r+

@bors
Copy link
Collaborator

bors commented Aug 2, 2016

📌 Commit 083ff01 has been approved by brson

@bors
Copy link
Collaborator

bors commented Aug 2, 2016

⌛ Testing commit 083ff01 with merge f4a23e7...

bors added a commit that referenced this pull request Aug 2, 2016
Always pass `-C metadata` to the compiler

If it's not otherwise available we just key it off the pkgid which should be
unique enough across compilations. This should help incremental compilation
efforts be "more incremental" across projects.

Closes #2943
@bors
Copy link
Collaborator

bors commented Aug 2, 2016

💔 Test failed - cargo-linux-32

@alexcrichton
Copy link
Member Author

@bors: retry

On Tue, Aug 2, 2016 at 11:54 AM, bors notifications@github.com wrote:

💔 Test failed - cargo-linux-32
https://buildbot.rust-lang.org/builders/cargo-linux-32/builds/1759


You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
#2946 (comment), or mute
the thread
https://github.com/notifications/unsubscribe-auth/AAD95JDckaFkC9Flzck_UkqCLuJuHH-oks5qb5JmgaJpZM4JaSAe
.

@bors
Copy link
Collaborator

bors commented Aug 2, 2016

⚡ Previous build results for cargo-cross-linux, cargo-linux-64, cargo-mac-32, cargo-mac-64, cargo-win-gnu-32, cargo-win-gnu-64, cargo-win-msvc-32, cargo-win-msvc-64 are reusable. Rebuilding only cargo-linux-32...

@bors
Copy link
Collaborator

bors commented Aug 2, 2016

☀️ Test successful - cargo-cross-linux, cargo-linux-32, cargo-linux-64, cargo-mac-32, cargo-mac-64, cargo-win-gnu-32, cargo-win-gnu-64, cargo-win-msvc-32, cargo-win-msvc-64
Approved by: brson
Pushing f4a23e7 to master...

@bors bors merged commit 083ff01 into rust-lang:master Aug 2, 2016
@alexcrichton alexcrichton deleted the build-script-metadata branch August 9, 2016 05:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants