Pass target environment for rustdoc

[matklad]

This should fix #3200, but I am not sure that this is a correct fix, and I need some input to figure this out.

rustdoc is invoked in two places, in cargo_test.rs and in cargo_rustc/mod.rs. Before the refactoring PR, these invocations used different LD_LIBRARY paths. The one in cargo_rustc used "host" version, while the one in cargo_test used "target" version.

The original PR changed both to "host", this PR switches both to "target". Is this correct, or should we stick with different environments for building documentation and doctests?

[rust-highfive]

r? @alexcrichton

(rust_highfive has picked a reviewer for you, use r? to override)

[alexcrichton]

I think this is correct, thanks! We can only run rustdoc tests in the case that host == target, so in that case it shouldn't matter which is used so long as both trigger the same library path logic.

@bors: r+

[bors]

📌 Commit 21cdb63 has been approved by alexcrichton

[bors]

⌛ Testing commit 21cdb63 with merge 6acf50f...

[bors]

💔 Test failed - cargo-win-gnu-64

[alexcrichton]

@bors: retry

On Mon, Oct 17, 2016 at 9:00 AM, bors notifications@github.com wrote:

💔 Test failed - cargo-win-gnu-64
https://buildbot.rust-lang.org/builders/cargo-win-gnu-64/builds/749

—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
#3205 (comment), or mute
the thread
https://github.com/notifications/unsubscribe-auth/AAD95MjVIIPZHUHFqKGP5CEltg2hBVhVks5q05uKgaJpZM4KYpWt
.

[bors]

⚡ Previous build results for cargo-linux-32, cargo-linux-64, cargo-mac-64, cargo-win-msvc-64 are reusable. Rebuilding only cargo-cross-linux, cargo-mac-32, cargo-win-gnu-32, cargo-win-gnu-64, cargo-win-msvc-32...

[bors]

💔 Test failed - cargo-win-gnu-64

[alexcrichton]

@bors: retry

On Mon, Oct 17, 2016 at 9:13 AM, bors notifications@github.com wrote:

💔 Test failed - cargo-win-gnu-64
https://buildbot.rust-lang.org/builders/cargo-win-gnu-64/builds/750

—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
#3205 (comment), or mute
the thread
https://github.com/notifications/unsubscribe-auth/AAD95Pn3lgDgVElTp8bTi7jku2p6EUKlks5q0565gaJpZM4KYpWt
.

[bors]

⚡ Previous build results for cargo-linux-32, cargo-linux-64, cargo-mac-32, cargo-mac-64, cargo-win-gnu-32, cargo-win-msvc-32, cargo-win-msvc-64 are reusable. Rebuilding only cargo-cross-linux, cargo-win-gnu-64...

[bors]

☀️ Test successful - cargo-cross-linux, cargo-linux-32, cargo-linux-64, cargo-mac-32, cargo-mac-64, cargo-win-gnu-32, cargo-win-gnu-64, cargo-win-msvc-32, cargo-win-msvc-64
Approved by: alexcrichton
Pushing 6acf50f to master...