Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix passing --features when testing multiple packages #3280

Merged
merged 1 commit into from
Nov 11, 2016

Conversation

alexcrichton
Copy link
Member

The wrong method was being passed to resolution accidentally. Features specified
via --features and --no-default-features are spec'd as only applying to the
current package, not all packages.

Closes #3279

The wrong method was being passed to resolution accidentally. Features specified
via `--features` and `--no-default-features` are spec'd as only applying to the
*current* package, not all packages.

Closes rust-lang#3279
@rust-highfive
Copy link

r? @brson

(rust_highfive has picked a reviewer for you, use r? to override)

@brson
Copy link
Contributor

brson commented Nov 11, 2016

@bors r+

@bors
Copy link
Collaborator

bors commented Nov 11, 2016

📌 Commit d21cb9a has been approved by brson

@bors
Copy link
Collaborator

bors commented Nov 11, 2016

⌛ Testing commit d21cb9a with merge 48f8f54...

bors added a commit that referenced this pull request Nov 11, 2016
Fix passing --features when testing multiple packages

The wrong method was being passed to resolution accidentally. Features specified
via `--features` and `--no-default-features` are spec'd as only applying to the
*current* package, not all packages.

Closes #3279
@bors
Copy link
Collaborator

bors commented Nov 11, 2016

💔 Test failed - cargo-win-gnu-64

@alexcrichton
Copy link
Member Author

@bors: retry

On Thursday, November 10, 2016, bors notifications@github.com wrote:

💔 Test failed - cargo-win-gnu-64
https://buildbot.rust-lang.org/builders/cargo-win-gnu-64/builds/795


You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
#3280 (comment), or mute
the thread
https://github.com/notifications/unsubscribe-auth/AAD95IVR2Gtp0uXvncUUwHU4e9S9giwLks5q87iEgaJpZM4KvSnY
.

@bors
Copy link
Collaborator

bors commented Nov 11, 2016

⚡ Previous build results for cargo-linux-32, cargo-linux-64, cargo-mac-32, cargo-mac-64, cargo-win-gnu-32, cargo-win-msvc-32, cargo-win-msvc-64 are reusable. Rebuilding only cargo-cross-linux, cargo-win-gnu-64...

@bors
Copy link
Collaborator

bors commented Nov 11, 2016

☀️ Test successful - cargo-cross-linux, cargo-linux-32, cargo-linux-64, cargo-mac-32, cargo-mac-64, cargo-win-gnu-32, cargo-win-gnu-64, cargo-win-msvc-32, cargo-win-msvc-64
Approved by: brson
Pushing 48f8f54 to master...

@bors bors merged commit d21cb9a into rust-lang:master Nov 11, 2016
@alexcrichton alexcrichton deleted the test-features branch November 11, 2016 03:20
@ehuss ehuss added this to the 1.14.0 milestone Feb 6, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

master rustc can't bootstrap off of cargo nightly-2016-11-02
5 participants