Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add cargo check --all #3731

Merged
merged 1 commit into from
Feb 21, 2017
Merged

Add cargo check --all #3731

merged 1 commit into from
Feb 21, 2017

Conversation

alexcrichton
Copy link
Member

This'll check all build targets for all packages in a workspace

@rust-highfive
Copy link

r? @brson

(rust_highfive has picked a reviewer for you, use r? to override)

@crumblingstatue
Copy link

Thanks, this gives symmetry with cargo build --all.

src/bin/check.rs Outdated
@@ -14,6 +14,7 @@ Usage:
Options:
-h, --help Print this message
-p SPEC, --package SPEC ... Package to check
--all Build all packages in the workspace
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

s/build/check/ ?

src/bin/check.rs Outdated
@@ -14,6 +14,7 @@ Usage:
Options:
-h, --help Print this message
-p SPEC, --package SPEC ... Package to check
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There is ... so both the help text and the flag name should be plural.

This'll check all `build` targets for all packages in a workspace
@matklad
Copy link
Member

matklad commented Feb 18, 2017

r+ from me :)

@alexcrichton
Copy link
Member Author

@bors: r=matklad

@bors
Copy link
Collaborator

bors commented Feb 21, 2017

📌 Commit 97c1bba has been approved by matklad

@bors
Copy link
Collaborator

bors commented Feb 21, 2017

⌛ Testing commit 97c1bba with merge d815930...

bors added a commit that referenced this pull request Feb 21, 2017
Add `cargo check --all`

This'll check all `build` targets for all packages in a workspace
@bors
Copy link
Collaborator

bors commented Feb 21, 2017

☀️ Test successful - status-appveyor, status-travis
Approved by: matklad
Pushing d815930 to master...

@bors bors merged commit 97c1bba into rust-lang:master Feb 21, 2017
@alexcrichton alexcrichton deleted the check-all branch March 1, 2017 15:02
@ehuss ehuss added this to the 1.17.0 milestone Feb 6, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants