Expose the target directory in cargo metadata #4022
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
r? @brson (rust_highfive has picked a reviewer for you, use r? to override) |
matklad
reviewed
May 10, 2017
tests/metadata.rs
Outdated
| @@ -566,6 +573,7 @@ const MANIFEST_OUTPUT: &'static str= | |||
| }], | |||
| "workspace_members": [ "foo 0.5.0 (path+file:[..]foo)" ], | |||
| "resolve": null, | |||
| "target_directory": "[..]foo/target", | |||
There was a problem hiding this comment.
The slashes won't work on windows. I think you can write [..]foo[/]target to select \ or /.
sfackler
force-pushed
the
metadata-target-dir
branch
from
3c507f8
to
a367875
Compare
|
Thanks! @bors r+ |
|
📌 Commit a367875 has been approved by |
bors
added a commit
that referenced
this pull request
May 10, 2017
Expose the target directory in cargo metadata Closes #4017
|
☀️ Test successful - status-appveyor, status-travis |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #4017