Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

3360 - Allow for features to be either comma or space delimited. #4084

Merged
merged 1 commit into from
May 22, 2017

Conversation

shiver
Copy link
Contributor

@shiver shiver commented May 22, 2017

This is my attempt at tackling issue #3360.
Hopefully I interpreted the original request correctly and this is what you were looking for.

Any suggestions you might have to improve the submission would be great.
Thanks!

@rust-highfive
Copy link

r? @alexcrichton

(rust_highfive has picked a reviewer for you, use r? to override)

@alexcrichton alexcrichton added the relnotes Release-note worthy label May 22, 2017
@alexcrichton
Copy link
Member

Looks great to me, thanks @shiver!

@bors: r+

@bors
Copy link
Collaborator

bors commented May 22, 2017

📌 Commit 72f8427 has been approved by alexcrichton

@bors
Copy link
Collaborator

bors commented May 22, 2017

⌛ Testing commit 72f8427 with merge 26d1d9d...

bors added a commit that referenced this pull request May 22, 2017
3360 - Allow for features to be either comma or space delimited.

This is my attempt at tackling issue #3360.
Hopefully I interpreted the original request correctly and this is what you were looking for.

Any suggestions you might have to improve the submission would be great.
Thanks!
@bors
Copy link
Collaborator

bors commented May 22, 2017

☀️ Test successful - status-appveyor, status-travis
Approved by: alexcrichton
Pushing 26d1d9d to master...

@bors bors merged commit 72f8427 into rust-lang:master May 22, 2017
@shiver shiver deleted the issue-3360 branch May 22, 2017 22:42
@ehuss ehuss added this to the 1.19.0 milestone Feb 6, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
relnotes Release-note worthy
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants