Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add fossil VCS support to cargo new #4155

Merged
merged 1 commit into from
Jun 14, 2017
Merged

Conversation

ketralnis
Copy link
Contributor

@ketralnis ketralnis commented Jun 10, 2017

Fossil is a simple, high-reliability, distributed software configuration management system https://www.fossil-scm.org/

I mostly followed #3842 as a template. Like that one, this only adds support for cargo new, not for pulling down fossil-hosted dependencies

A problem that i didn't tackle but I'd be willing to is a little more more traitifying of the VCSs. I would need some guidance on that since it looks like git has some more thorough support than e.g. hg does but it looks pretty doable

@rust-highfive
Copy link

Thanks for the pull request, and welcome! The Rust team is excited to review your changes, and you should hear from @brson (or someone else) soon.

If any changes to this PR are deemed necessary, please add them as extra commits. This ensures that the reviewer can see what has changed since they last reviewed the code. Due to the way GitHub handles out-of-date commits, this should also make it reasonably obvious what issues have or haven't been addressed. Large or tricky changes may require several passes of review and changes.

Please see the contribution instructions for more information.

Fossil is a simple, high-reliability, distributed software configuration
management system <https://www.fossil-scm.org/>
@ketralnis
Copy link
Contributor Author

There's a CI failure but it looks like it's happening in Windows stuff that I don't think I can have touched?

error: failed to run custom build command for `libz-sys v1.0.13`
process didn't exit successfully: `C:\projects\cargo\target\debug\build\libz-sys-7b5eea371d27baa2\build-script-build` (exit code: 1)
--- stdout
running: "C:\\Program Files (x86)\\Microsoft Visual Studio 14.0\\VC\\bin\\amd64\\nmake.exe" "/nologo" "/f" "C:\\projects\\cargo\\target\\debug\\build\\libz-sys-0598af38eaebd697\\out\\build/win32/Makefile.msc" "zlib.lib"
command did not execute successfully, got: exit code: 2
--- stderr
Microsoft (R) Program Maintenance Utility Version 14.00.24210.0
Copyright (C) Microsoft Corporation.  All rights reserved.
NMAKE : fatal error U1065: invalid option '-'
Stop.
Build failed, waiting for other jobs to finish...
error: build failed
Command exited with code 101

@alexcrichton
Copy link
Member

@bors: r+

Thanks! That error may bounce this PR but I'll take care of it, no worries!

@bors
Copy link
Collaborator

bors commented Jun 13, 2017

📌 Commit 7eca7f2 has been approved by alexcrichton

@bors
Copy link
Collaborator

bors commented Jun 13, 2017

⌛ Testing commit 7eca7f2 with merge 0279815...

@bors
Copy link
Collaborator

bors commented Jun 13, 2017

💔 Test failed - status-appveyor

@Mark-Simulacrum
Copy link
Member

@bors retry

Looks like the spurious failure noted above.

@alexcrichton
Copy link
Member

@bors: retry

@bors
Copy link
Collaborator

bors commented Jun 13, 2017

⌛ Testing commit 7eca7f2 with merge faa7668...

@bors
Copy link
Collaborator

bors commented Jun 14, 2017

💔 Test failed - status-travis

@alexcrichton
Copy link
Member

alexcrichton commented Jun 14, 2017 via email

@bors
Copy link
Collaborator

bors commented Jun 14, 2017

⌛ Testing commit 7eca7f2 with merge e934177...

bors added a commit that referenced this pull request Jun 14, 2017
Add fossil VCS support to `cargo new`

Fossil is a simple, high-reliability, distributed software configuration management system <https://www.fossil-scm.org/>

I mostly followed #3842 as a template. Like that one, this only adds support for `cargo new`, not for pulling down fossil-hosted dependencies

A problem that i didn't tackle but I'd be willing to is a little more more `trait`ifying of the VCSs. I would need some guidance on that since it looks like git has some more thorough support than e.g. hg does but it looks pretty doable
@bors
Copy link
Collaborator

bors commented Jun 14, 2017

☀️ Test successful - status-appveyor, status-travis
Approved by: alexcrichton
Pushing e934177 to master...

@bors bors merged commit 7eca7f2 into rust-lang:master Jun 14, 2017
@ketralnis
Copy link
Contributor Author

Awesome! Thanks all!

@ehuss ehuss added this to the 1.20.0 milestone Feb 6, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants