Make cargo-the-binary version the same as the Rust version #5083
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
(rust_highfive has picked a reviewer for you, use r? to override) |
matklad
force-pushed
the
Cargo-the-tool-1.0
branch
from
d71da8b
to
cc971ee
Compare
|
@bors: r+ |
|
📌 Commit cc971ee has been approved by |
bors
added a commit
that referenced
this pull request
Feb 26, 2018
Make cargo-the-binary version the same as the Rust version Closes #4211 which seems stuck :-) Soooo, this is the simplest possible fix to this problem: ``` ~/projects/cargo Cargo-the-tool-1.0 λ rustc --version rustc 1.24.0 (4d90ac38c 2018-02-12) ~/projects/cargo Cargo-the-tool-1.0 λ cargo --version cargo 0.25.0 (8c93e08 2018-02-01) ``` It makes `cargo --version` to print the corresponding Rust version (with possibly cargo-specific patch number), while keeping the library version the same as today. On the one hand, this is horrible. On the other hand, it seems to do the job? In the long term, it would be cool skip one version bump for the library, so that `0.x` corresponds to `1.x`. cc @rust-lang/cargo I am not sure that this is good idea, the implementation certainly feels horrible :)
|
☀️ Test successful - status-appveyor, status-travis |
bors
added a commit
to rust-lang/rust
that referenced
this pull request
Jul 27, 2018
…acrum [beta] Bump bootstrap compiler to 1.27.2 This PR bumps the beta bootstrap compiler to 1.27.2. * The original cargo version was wrong: the current one is not `0.28.0`, but `1.27.0` (since rust-lang/cargo#5083). [Should the forge be updated?](https://forge.rust-lang.org/release-process.html) * The updated `date` is the correct one for rustc, but the wrong one for cargo. *I think* that shouldn't cause any problem, but it's better to ask. r? @Mark-Simulacrum
moshg
pushed a commit
to moshg/rust-std-ja
that referenced
this pull request
Apr 4, 2020
…acrum [beta] Bump bootstrap compiler to 1.27.2 This PR bumps the beta bootstrap compiler to 1.27.2. * The original cargo version was wrong: the current one is not `0.28.0`, but `1.27.0` (since rust-lang/cargo#5083). [Should the forge be updated?](https://forge.rust-lang.org/release-process.html) * The updated `date` is the correct one for rustc, but the wrong one for cargo. *I think* that shouldn't cause any problem, but it's better to ask. r? @Mark-Simulacrum
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #4211 which seems stuck :-)
Soooo, this is the simplest possible fix to this problem:
It makes
cargo --versionto print the corresponding Rust version (with possibly cargo-specific patch number), while keeping the library version the same as today.On the one hand, this is horrible. On the other hand, it seems to do the job? In the long term, it would be cool skip one version bump for the library, so that
0.xcorresponds to1.x.cc @rust-lang/cargo
I am not sure that this is good idea, the implementation certainly feels horrible :)