Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding feature-flags to cargo publish and cargo package #6453

Merged
merged 5 commits into from
Jan 10, 2019

Commits on Dec 26, 2018

  1. Adding feature-flags to cargo publish and cargo package

    This change adds the `--features` and `--all-features` flags to the
    above mentioned commands. This is to allow publishing of crates that
    have certain feature requirements for compilation, without having to
    rely on `--no-verify` which isn't good practise.
    
    This PR adds two new fields `features` and `all_features` to both the
    `PackageOpts` and `PublishOpts` and also adds the argument options
    to the CLI commands.
    
    Merging this feature will allow people to publish crates on crates.io
    that require some feature flag to compile (or all?) without needing
    to rely on not checking the package before uploading, potentially
    resulting in less packaging errors and broken packages.
    spacekookie committed Dec 26, 2018
    Configuration menu
    Copy the full SHA
    256fc39 View commit details
    Browse the repository at this point in the history

Commits on Dec 29, 2018

  1. Configuration menu
    Copy the full SHA
    142bafb View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    40cca80 View commit details
    Browse the repository at this point in the history

Commits on Jan 9, 2019

  1. Fixing the publish tests

    spacekookie committed Jan 9, 2019
    Configuration menu
    Copy the full SHA
    8c3bf82 View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    b29e379 View commit details
    Browse the repository at this point in the history