Fix erroring when explicitly using "--features default" without specifying one in Cargo.toml #8220
Conversation
|
r? @Eh2406 (rust_highfive has picked a reviewer for you, use r? to override) |
rust-highfive
added
the
S-waiting-on-review
hbina
changed the title
| @@ -265,6 +265,8 @@ pub fn resolve_features<'b>( | |||
| let reqs = build_requirements(s, opts)?; | |||
| let mut ret = Vec::new(); | |||
| let mut used_features = HashSet::new(); | |||
| // Add `default` as a feature that must exist. | |||
| used_features.insert("default".into()); | |||
There was a problem hiding this comment.
I think the only read of used_features is below at .filter(|s| !used_features.contains(s)).
Std::HashSet only allocates when something is added, and this set is only used if there are enabled optional dependencies. So maybe if we add a .filter(|s| s != "default") then we can avoid the allocation here.
(yes, I know, this is micro optimizing when not on the hot path.)
|
The CI problems were fixed by rerunning. I added a micro optimizing nit. |
|
☔ The latest upstream changes (presumably #8395) made this pull request unmergeable. Please resolve the merge conflicts. |
Also added a regression test for this.
hbina
force-pushed
the
fix_default_features
branch
from
065f25c
to
be5bebb
Compare
|
Closing as this as become somewhat stale, and per #8164 (comment) it is not really clear that we want to change the behavior here. |
Also added a regression test for this.
This will likely cause a problem if a crate specify a "default" feature.
Related: #8164
Edit: This solutions feels clumsy at best xD