apply playpen by default #104
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks this is awesome! But AFAIK playpen doesn't support "extern crate" definitions. I don't think it is usable for crates in docs.rs or crates.io. An example from rand crate: https://is.gd/B7FUQf |
|
yes, playpen should solve this issue first. cc rust-lang/rust-playpen#67 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The standard library API docs allow us running example code at https://play.rust-lang.org/ (which powered by playpen). But there're only very little amount of crates (i.g. num, frunk, rusqbin) on crates.io have this feature. Most other crate authors don't know about
#![doc(html_playground_url = "https://play.rust-lang.org/")], or forget adding it to crate root.Since rustdoc has
--playground-urloption (cc rust-lang/rust#37763), it's time to apply playpen by default to all crates.io crates. For crates have their own#![doc(html_playground_url = "URL")], nothing will be changed.