Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update conditional-compilation.md #502

Merged
merged 1 commit into from
Jan 9, 2019
Merged

Conversation

jethrogb
Copy link
Contributor

@jethrogb jethrogb commented Jan 9, 2019

No description provided.

@Centril Centril added S-waiting-on-stabilization Waiting for a stabilization PR to be merged in the main Rust repository RFC Stabilization Docs Documentation required for stabilizing a feature labels Jan 9, 2019
@nagisa
Copy link
Member

nagisa commented Jan 9, 2019

IMHO you could just replace "possible values" with "Example values" to match the other target cfgs. This is the more appropriate way to do it either way.

@nagisa
Copy link
Member

nagisa commented Jan 9, 2019

Erhm, I wrote that comment above before double-checking the PR. It seems you did exactly that!

Copy link
Contributor

@Havvy Havvy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lgtm.

@Havvy Havvy merged commit 5865673 into rust-lang:master Jan 9, 2019
jethrogb added a commit to jethrogb/reference that referenced this pull request Jan 10, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
RFC Stabilization Docs Documentation required for stabilizing a feature S-waiting-on-stabilization Waiting for a stabilization PR to be merged in the main Rust repository
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants