Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

No Hash for std::time::SystemTime #46670

Closed
vi opened this issue Dec 11, 2017 · 1 comment
Closed

No Hash for std::time::SystemTime #46670

vi opened this issue Dec 11, 2017 · 1 comment
Labels
C-feature-accepted Category: A feature request that has been accepted pending implementation. T-libs-api Relevant to the library API team, which will review and decide on the PR/issue.

Comments

@vi
Copy link
Contributor

vi commented Dec 11, 2017

For example, it stops Rustbreak from handling structures containing SystemTime.
@Mark-Simulacrum Mark-Simulacrum added C-feature-request Category: A feature request, i.e: not implemented / a PR. T-libs-api Relevant to the library API team, which will review and decide on the PR/issue. labels Dec 12, 2017
@dtolnay dtolnay added C-feature-accepted Category: A feature request that has been accepted pending implementation. and removed C-feature-request Category: A feature request, i.e: not implemented / a PR. labels Dec 18, 2017
@dtolnay
Copy link
Member

dtolnay commented Dec 18, 2017

I would be prepared to consider a PR adding an impl Hash for SystemTime.

@vi vi mentioned this issue Dec 18, 2017
Merged
bors pushed a commit that referenced this issue Dec 19, 2017
@vi
Add Hash impl for SystemTime and Instant
1d5ead4 
Closes #46670.
kennytm added a commit to kennytm/rust that referenced this issue Dec 20, 2017
@kennytm
Rollup merge of rust-lang#46828 - vi:hash_for_systemtime_instant, r=d…
5e98112 
…tolnay

Add Hash impl for SystemTime and Instant

Closes rust-lang#46670.

Not sure how to actually test non-Linux platforms.
`rustc --target=i686-pc-windows-gnu --crate-name std --crate-type rlib src/libstd/lib.rs -o q.rlib` works a bit, but for Redox I'm not sure what to do.

r? @dtolnay
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
C-feature-accepted Category: A feature request that has been accepted pending implementation. T-libs-api Relevant to the library API team, which will review and decide on the PR/issue.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@vi @dtolnay @Mark-Simulacrum